1634272 - Navigating home from some other site doesn't focus the addressbar (regression)

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[juraj.masiar]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

1. install Group Speed Dial extension:
   https://addons.mozilla.org/sk/firefox/addon/groupspeeddial/
2. click its toolbar icon / Options
3. in the Options page, click the "Copy homepage link" button (first line)
4. open "about:preferences#home" page and change the "Homepage and new windows" to "Custom URLs" and paste there the link
5. open New tab
6. type to addressbar "github.com" and press enter
7. press "Alt + Home" short-key

Actual results:

Addressbar is NOT focused

Expected results:

Addressbar should be focused.
This works in release 75 and ESR 68.
I can reproduce it in Beta 76.0b8 and Nightly 77

Comment 1

[Alex Cornestean]

Hello,

I have managed to reproduce the issue based on the provided STR on the latest Nightly (78.0a1/20200506215114), Beta (77.0b2/20200505174119) and Release (76.0/20200429185419) under Windows 10 Pro 64-bit and macOS Catalina 10.15. The address bar is indeed not focused upon using the ‘Alt+Home’ shortcut.

Also tested the 75.0 Release version (75.0/ 20200403170909), where the issue does not occur i.e. the address bar is properly focused.

Furthermore, I have performed a regression range on the issue, narrowing it down to https://bugzilla.mozilla.org/show_bug.cgi?id=1597154 (2020-05-07T13:43:22.440000: DEBUG : Found commit message: Bug 1597154 - pt 4. Rename SchemeUsesDocChannel r=mattwoodrow), with this differential revision: https://phabricator.services.mozilla.com/D59823 .

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=438d5f4b2417959856efba5a99706f68fe4ba5eb&tochange=08b92b1c769e00398129dfb434c901de4ec2ec26 .

Comment 2

[Paul Bone [:pbone]]

I suspect this is related to Bug 1626507. I'll work on it soon, likely next week.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Pascal Chevrel:pascalc]

Paul, you marked it as P1, are you planning an uplift to beta or is it safe to assume that the fix will ship with 78? (last beta before RC is this Friday) Thanks

Comment 5

[Paul Bone [:pbone]]

(In reply to Pascal Chevrel:pascalc from comment #4)

Paul, you marked it as P1, are you planning an uplift to beta or is it safe to assume that the fix will ship with 78? (last beta before RC is this Friday) Thanks

78 but more likely 79. I havn't started investigating this.

Comment 6

[Paul Bone [:pbone]]

For me the extension doesn't seem to make a difference, the address bar isn't focused when I am on github.com then press Alt+Home. It is focused when I open a new tab or window. The same with and without the extension, and with and without the change to the homepage URL. Does that make sense juraj.masiar?

Comment 7

[juraj.masiar]

Actually yes. Only when the homepage is Blank Page, it will work even now.
I've been testing it with new profile (created with web-ext) where the Blank Page is homepage by default.
So yes, setting homepage to Firefox Home will trigger the bug as well.

Comment 8

[Paul Bone [:pbone]]

Although I'm unsure what the browser "should" do, earlier versions focus the address bar in all cases, and that seems consistent so I think it should probably do that.

Comment 9

[Paul Bone [:pbone]]

Attachment: Bug 1634272 - Don't use DocumentChannel for about:newtab r=mattwoodrow

To avoid this regression we can avoid DocumentChannel because it'll probably
be fixed by Bug 1626507.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf162b065e1f
Don't use DocumentChannel for about:newtab r=mattwoodrow

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bf162b065e1f

Comment 12

[juraj.masiar]

Hello Paul,
I've tested the Nightly today and while the fix works with "about:newtab", it doesn't work if the homepage is extension page (which was the original issue). Could you please check? Thanks!

Comment 13

[Paul Bone [:pbone]]

Hi Juraj,

I've filed a new bug to describe your original problem Bug 1643578. I can also reproduce it.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:pbone, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Paul Bone [:pbone]]

No, we can let it ride the trains, it's minor and it's been in release a while now.

Comment 16

[Ciprian Georgiu, Desktop QA]

I was able to reproduce the issue described in comment 0, using an affected Nightly build from 2020-04-30.

As stated in comment 12, the issue doesn't reproduce anymore with "about:newtab" set as homepage, but it does reproduce if an extension is set as homepage. Given the fact that latter is tracked in bug 1643578, I will mark this as verified fixed. Tested on 79.0b3 across platforms: Win 10 x64, macOS 10.15 and Ubuntu 18.04 x64.

Comment 17

[Oana Botisan, Desktop QA]

Just as a heads up, this issue is still reproducing on Firefox 78.1 esr. I am guessing that is expected at the moment considering the fact that the bug has the status wontfix for firefox 78.

Comment 18

[Paul Bone [:pbone]]

In my opinion this is a small problem causing only inconvenience. it's not worth backporting to an ESR.