Closed Bug 1626606 Opened 4 years ago Closed 4 years ago

Disable WarpBuilder for some jit-tests that pattern match error messages

Categories

(Core :: JavaScript Engine: JIT, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Ion frames don't get the expression decompiler and this can show up as test failures with --ion-eager --warp because, unlike IonBuilder, we don't bail out to Baseline as much.

This covers the function.arguments issue discussed in bug 1626294 and the expression
decompiler being disabled for Ion frames (bug 831120). It gets us from 29 to 18 failures
with --ion-eager --no-threads --warp.

I considered looking into the expression decompiler issue more, but it's not easy and
disabling the expression decompiler might be the sanest thing to do anyway to avoid
confusing error messages.

Priority: -- → P2
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb399bc62a10
Disable WarpBuilder for some jit-tests. r=iain
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: