1626615 - Fix debugger forced-return propagation for Ion frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

This is triggered by jit-test/tests/debug/Frame-onStep-resumption-05.js with WarpBuilder enabled.

In HandleExceptionIon we check whether the realm is a debuggee, but this doesn't handle the case where the realm is no longer a debuggee but we're still propagating a forced return.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1626615 - Fix forced-return propagation for Ion frames after debugger has been disabled. r?loganfsmyth!

With WarpBuilder enabled we failed the Frame-onStep-resumption-05.js jit-test. This
failed because when we are propagating a forced-return and turn off the debugger,
we ignored this forced-return for Ion frames. This patch fixes that test failure.

It also tidies up the code with a ShouldBailoutForDebugger helper function.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d282675fe94
Fix forced-return propagation for Ion frames after debugger has been disabled. r=loganfsmyth

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4d282675fe94