1626762 - nsPSPrinters.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1626761 +++

Filling as a good first bug to learn workflows.

  if (StringBeginsWith(aName, NS_LITERAL_CSTRING(NS_POSTSCRIPT_DRIVER_NAME)))
    return kTypePS;
  else if (StringBeginsWith(aName, NS_LITERAL_CSTRING(NS_CUPS_PRINTER)))
    return kTypeCUPS;
  else
    return kTypeUnknown;

do not use 'else' after 'return'

please also note that { } should be added (even for one line)

https://searchfox.org/mozilla-central/source/widget/gtk/nsPSPrinters.cpp#103-108

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[ryan.pauls67]

Attachment: Bug 1626762 Removed the else statement to improve readability and better meet guidelines as per http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html r?ehsan

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/960689967110
Removed the else statement to improve readability and better meet guidelines as per http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html r=sylvestre

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/960689967110