1626772 - Update hazard analysis to gcc 9

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

Over in bug 1623278, a code modification incorrect generated an error in gcc 8, although it worked in gcc 7 and gcc 9.

Upgrading sixgill from gcc 8 to 9 turned out to be very easy, though Gecko code needs a few adjustments for enhanced gcc 9 warnings.

I would rather be on the same gcc version as other gcc jobs, but currently they're on gcc 7 which has a bug that sixgill hits. So if I can't be on the same version, perhaps it's more useful to be blazing a trail to the next gcc upgrade. (Fedora 31 already uses gcc 9, at least.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1626772 - Fixes for gcc 9 warnings

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1626772 - Update hazard analysis to gcc 9

Also requires modifying an annotation for altered gcc 9 output format.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1626772 - gcc compatibility hack for __attribute__ and mutable ordering in lambda decl

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4026a9f380
Fixes for gcc 9 warnings r=botond
https://hg.mozilla.org/integration/autoland/rev/ab5b637f714a
Update hazard analysis to gcc 9 r=froydnj
https://hg.mozilla.org/integration/autoland/rev/f42150bdee2b
gcc compatibility hack for __attribute__ and mutable ordering in lambda decl r=glandium

Comment 5

[Alexandru Michis [:malexandru]]

Backed out 3 changesets for causing bustages in DefineEnum.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/2bf70f175c453a720ca47b871619f95f4b96f6c3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=676749&tochange=b21b9142dcbf850c201002672ab5cd24b2a4701e&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-fuzzing%2Fdebug%2C%28bf%29&fromchange=b6fd7b67139a9915b286a6827bc12741847ee1d7&selectedJob=297061615

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297061615&repo=autoland&lineNumber=21357

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dba8c1976764
Fixes for gcc 9 warnings r=botond
https://hg.mozilla.org/integration/autoland/rev/d6222dce150a
Update hazard analysis to gcc 9 r=froydnj
https://hg.mozilla.org/integration/autoland/rev/00a9695bcb94
gcc compatibility hack for __attribute__ and mutable ordering in lambda decl r=glandium

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dba8c1976764
https://hg.mozilla.org/mozilla-central/rev/d6222dce150a
https://hg.mozilla.org/mozilla-central/rev/00a9695bcb94