1626794 - Make Animation::CommitStyles safer

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Emily McDonough [:alaskanemily]]

There are two main issues with Animation::CommitStyles.
1: Animation::CommitStyles calls Document::FlushPendingNotifications which means that it should have the MOZ_CAN_RUN_SCRIPT annotation.
2: It doesn't explicitly account for the possibility that flushing the document could destroy the document.

For 2 it's currently safe because it holds a strong reference to the element and checks for a null prescontext before applying styles, but how it's currently implemented it could b easy to miss this case when modifying the function.

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1626794 - Add strong ref to document and MOZ_CAN_RUN_SCRIPT annotation to Animation::CommitStyles

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ec3a730a72f
Add strong ref to document and MOZ_CAN_RUN_SCRIPT annotation to Animation::CommitStyles r=hiro

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1ec3a730a72f