Cleanup arguments-objects flags in frontend
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(4 files)
With the introduction of resetArgsUsageAnalysis() we can deprecate all the old calls to BaseScript::setArgumentsHasVarBinding. As well, we can use SharedContext::immutableFlags to hold the frontend's flags to track this stuff.
|
Assignee | |
Comment 1•4 years ago
|
||
This replaces the dedicated bools in FunctionBox with the associated
ImmutableFlags. The results in AlwaysNeedsArgsObj now being initialized
consistently for lazy scripts as well.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Instead, use resetArgsUsageAnalysis(). We no longer set the arguments flags
for lazy scripts since the mutable flags are imprecise until the BCE is
complete.
Depends on D69309
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1b94e00648f2 Use immutableFlags for ArgsObj flags in funbox. r=mgaudet https://hg.mozilla.org/integration/autoland/rev/569f0a43c304 Remove BaseScript::setArgumentsHasVarBinding. r=mgaudet
|
|
Assignee | |
Comment 4•4 years ago
|
||
Replace with the standard flag accessor: needsArgsAnalysis().
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D69430
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7439b0f68f49 Remove JSScript::analyzedArgsUsage. r=anba https://hg.mozilla.org/integration/autoland/rev/61c3c9168b93 Remove stale comments about args-analysis. r=anba
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1b94e00648f2
https://hg.mozilla.org/mozilla-central/rev/569f0a43c304
https://hg.mozilla.org/mozilla-central/rev/7439b0f68f49
https://hg.mozilla.org/mozilla-central/rev/61c3c9168b93
Description
•