Closed Bug 1626852 Opened 4 months ago Closed 4 months ago

WarpBuilder: turn off copy-on-write arrays for now

Categories

(Core :: JavaScript Engine: JIT, task, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1626852 - Turn off copy-on-write arrays if TI is disabled for now. r?iain!
47 bytes, text/x-phabricator-request
Details | Review

Ion CacheIR code for SetElem relies on a separate MIR instruction checking for this.

I think for now the best thing to do is turn this off to simplify our object model and then re-evaluate adding this back later, maybe when we get to optimizing SetElem. We'll probably want a BaseShape flag for COW and frozen elements.

SetElem IC code in Ion currently assumes a separate MIR instruction is used to
deal with copy-on-write elements. For now turn off copy-on-write arrays until
we can support them properly (bug 1626854).

Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b8fcc1836ce
Turn off copy-on-write arrays if TI is disabled for now. r=iain

https://hg.mozilla.org/mozilla-central/rev/1b8fcc1836ce

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.