Closed
Bug 1626852
Opened 5 years ago
Closed 5 years ago
WarpBuilder: turn off copy-on-write arrays for now
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
Ion CacheIR code for SetElem relies on a separate MIR instruction checking for this.
I think for now the best thing to do is turn this off to simplify our object model and then re-evaluate adding this back later, maybe when we get to optimizing SetElem. We'll probably want a BaseShape flag for COW and frozen elements.
Assignee | ||
Comment 1•5 years ago
•
|
||
SetElem IC code in Ion currently assumes a separate MIR instruction is used to
deal with copy-on-write elements. For now turn off copy-on-write arrays until
we can support them properly (bug 1626854).
Updated•5 years ago
|
Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b8fcc1836ce
Turn off copy-on-write arrays if TI is disabled for now. r=iain
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•