1626967 - Cranelift: preparatory refactorings for new-isel integration

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1626967: Use the regular Cranelift sinks to keep track of relocations; r=rhunt

This goes hand in hand with
https://github.com/bytecodealliance/wasmtime/pull/1460, which will need to be
merged first.

This removes most of the Spidermonkey-specific machinery to collect
relocations. The only remaining place is for stack-maps, which will be handled
later.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1626967: Use snake_case in shared Cranelift data structures; r=rhunt

This favors Rust, but there's no way to generate different names in the
bindings, as far as I know.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1626967: Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt

This avoids one platform-specific number (3 for x86_64, 4 for arm64).

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1626967: bump Cranelift to 6a68130d5b0296379fae0b8de5fbb8a1499b67a5; r=jseward

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29aaf3ff21ea
bump Cranelift to 6a68130d5b0296379fae0b8de5fbb8a1499b67a5; r=jseward
https://hg.mozilla.org/integration/autoland/rev/f48ad40e60af
Use the regular Cranelift sinks to keep track of relocations; r=rhunt
https://hg.mozilla.org/integration/autoland/rev/837dab8ce31c
Use snake_case in shared Cranelift data structures; r=rhunt
https://hg.mozilla.org/integration/autoland/rev/985eea91c36c
Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/29aaf3ff21ea
https://hg.mozilla.org/mozilla-central/rev/f48ad40e60af
https://hg.mozilla.org/mozilla-central/rev/837dab8ce31c
https://hg.mozilla.org/mozilla-central/rev/985eea91c36c

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for breaking Raptor tests godot-c and wm-c:

https://hg.mozilla.org/integration/autoland/rev/881935e4aa214dfb5b601b98ea01ded4299ead7d

Due to a misconfiguration, they run as tier-1 but only on mozilla-central: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=296745910&searchStr=rap&revision=6c6c67870c37b2e414f898e390ed5247d8e1e94a
They also have to run on autoland or as tier-2.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged https://hg.mozilla.org/mozilla-central/rev/881935e4aa21

Comment 9

[Benjamin Bouvier [:bbouvier] (inactive)]

Manually rebased and queued for re-landing (it wasn't this bug which caused the error which lead to this backout).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef939dda0a03
bump Cranelift to 6a68130d5b0296379fae0b8de5fbb8a1499b67a5; r=jseward
https://hg.mozilla.org/integration/autoland/rev/fb80ccae7376
Use the regular Cranelift sinks to keep track of relocations; r=rhunt
https://hg.mozilla.org/integration/autoland/rev/b44cac1aa5f1
Use snake_case in shared Cranelift data structures; r=rhunt
https://hg.mozilla.org/integration/autoland/rev/09c016706d3f
Provide Cranelift the size of wasm::Frame from a StaticEnvironment value; r=rhunt

Comment 11

[Benjamin Bouvier [:bbouvier] (inactive)]

(Had to rebase manually again, duh.)

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ef939dda0a03
https://hg.mozilla.org/mozilla-central/rev/fb80ccae7376
https://hg.mozilla.org/mozilla-central/rev/b44cac1aa5f1
https://hg.mozilla.org/mozilla-central/rev/09c016706d3f