Closed Bug 1627496 Opened 4 years ago Closed 4 years ago

Replace MOZ_MUST_USE with [[nodiscard]] in toolkit/crashreporter

Categories

(Toolkit :: Crash Reporting, task, P3)

Product:
Toolkit
Component:
Crash Reporting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Bug 1627496 - Replace MOZ_MUST_USE with [[nodiscard]] in toolkit/crashreporter. r?gsvelto
47 bytes, text/x-phabricator-request
Details | Review

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1f1f9869afe
Replace MOZ_MUST_USE with [[nodiscard]] in toolkit/crashreporter. r=gsvelto

https://hg.mozilla.org/mozilla-central/rev/c1f1f9869afe

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: