1627685 - Resizing the browser to min-width resets the search bar width after restoring the window to normal size, making the spacer next to it wider than usual

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Itiel]

STR:

1. Latest Nightly
2. Add search bar to the toolbar
3. Drag the resizer between the urlbar and the search bar in a way that the spacers to the left and right do not get smaller or bigger
4. Resize the browser window width to the smallest possible
5. Restore the window to normal

AR:

1. The search bar's width gets reset
2. The spacer after the search bar gets wider than usual

ER:

1. The previously customized search bar's width is retained
2. The spacer after the search bar is at normal width

Comment 1

[:Gijs (he/him)]

I can reproduce (1) (the search bar's width gets reset) but not (2). Can you post a screencast of what you do to help me understand?

Comment 2

[Itiel]

This is on a new profile:
https://s6.gifyu.com/images/Screencast-2.gif
(Sorry, for some reason I can't upload to bugzilla files > 1mb)
I used the mozregression window position as a reference to how the url+searchbar combined length look like originally.

Note that depends on how your urlbar and/or search bar are customized, both spacers can get wider, not just to one next to the search bar.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1627685 - do not wipe out widths if the search bar only overflows temporarily, r?dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75f52a2beb3d
do not wipe out widths if the search bar only overflows temporarily, r=dao

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/75f52a2beb3d

Comment 6

[Cristian Fogel [:cfogel]]

Confirmed issue with 76.0a1 (2020-04-06) on macOS 10.15.3/Windows 10.
Fix verified with 77.0b3 on macOS 10.15.3, Windows 10, Ubuntu 20.