1616639 - Spacers can get noticably thinner, and even restoring toolbar defaults doesn't fix it

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Itiel]

STR:

1. Clean profile
2. Open about:preferences#search and select the "Add search bar in toolbar" option
3. Drag the resizer between the urlbar and the search bar to the farthest left (you'll see at this point that the left spacer gets thin)
4. Do the same, now to the farthest right
5. In the same about:preferences page select the "Use the address bar for search and navigation" option

AR:
The spacers now get really thin. Going back to customize mode, the restore defaults button is disabled (i.e. the current state is allegedly already the default). Even if you make changes and restore defaults, the spacers are still thin.

ER:
Normal behaviour of the spacers.

Comment 1

[Itiel]

Will, as I can't reproduce what you're seeing in bug 1614238 comment 7 on a clean profile without doing the STR mentioned above, I think this happens to you because at some point in time you've added a search bar in the affected profile, did the above STR, and since then you've removed it and you're "stuck" with this.

There's bug 1601334 which increased the url min-width a little, but nothing drastic like your screenshots in bug 1614238. And even then, that bug was fixed in 74, and you're saying your issue was introduced in 75...

Comment 2

[Will]

Itiel you figured it out, you're awesome. I just reprod in 75 nightly

Comment 3

[Dão Gottwald [:dao]]

I suspect the right fix here is to have Restore Default remove the custom urlbar width.

Comment 4

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #3)

I suspect the right fix here is to have Restore Default remove the custom urlbar width.

I'm confused; why does the URL bar width affect the size of the spacer?

Comment 5

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #4)

(In reply to Dão Gottwald [::dao] from comment #3)

I suspect the right fix here is to have Restore Default remove the custom urlbar width.

I'm confused; why does the URL bar width affect the size of the spacer?

I think that's just how -moz-box layout works...

Comment 6

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #3)

I suspect the right fix here is to have Restore Default remove the custom urlbar width.

We could also do it when we remove the splitter (in UpdateUrlbarSearchSplitterState).

The downside of using "restore default" is that if people use the prefs (or manually remove the search bar via the context menu or dragging in customize mode), they will keep the width on the URL bar. Though I guess this also provides users with an ability to customize a minimum width for the url bar (ie add search bar, resize url bar, remove search bar again), that's not intentional right now, and I'm not sure we really care about supporting that going forward?

The downside of doing it when removing the splitter is that the url bar / search bar customization is lost as soon as users toggle the pref once and back.

Which do you think is preferable?

Comment 7

[Dão Gottwald [:dao]]

Doing this in UpdateUrlbarSearchSplitterState sounds good to me.

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1616639 - revert url bar and search bar width when removing the search bar from the navbar, r?dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a832aa80dd13
revert url bar and search bar width when removing the search bar from the navbar, r=dao

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a832aa80dd13

Comment 11

[Cristian Fogel [:cfogel]]

Confirmed issue with 75.0a1 (2020-02-19) on macOS 10.15.3.
Fix verified with 76.0b6 on macOS 10.15.3, Ubuntu 18.04, Windows 10.