Closed Bug 1627805 Opened 11 months ago Closed 10 months ago

Enable update agent to get the update directory path

Categories

(Toolkit :: Application Update, task)

Unspecified
Windows
task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: bytesized, Assigned: bytesized)

References

Details

Attachments

(2 files)

The update agent will need access to the update directory for its instance of Firefox. A complicating factor is that the update directory, if it doesn't exist, absolutely must be created with the correct permissions (which is currently done by the update directory path generation function). This means that, ideally, we shouldn't duplicate this functionality, but should instead reuse or, if necessary, rewrite the existing functionality.

The functionality currently lives here. It doesn't use any XUL code, but it is written in C++, which makes it difficult to link to from Rust.

I've posted a patch that almost works. It builds updatecommon.lib, and links the update agent to it. Unfortunately, the two things are not properly linked in the dependency graph, so I believe that whether or not ./mach build builds on the first try ends up being a race condition.

The update agent links against updatecommon (/toolkit/mozapps/update/common), but it does so in a mechanism that our build system doesn't actually support. This patch ensures that the updatecommon library will be built before the update agent, so that the update agent can link successfully.

Depends on D69875

Attachment #9139195 - Attachment description: Bug 1627805 - Enforce update agent build ordering → Bug 1627805 - Allow the update agent to link against updatecommon
Attachment #9138641 - Attachment description: Bug 1627805 - Obtain path for the download XML → Bug 1627805 - Obtain path for the download XML r=agashlin
Attachment #9139195 - Attachment description: Bug 1627805 - Allow the update agent to link against updatecommon → Bug 1627805 - Allow the update agent to link against updatecommon r=glandium
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fde1306bba7
Obtain path for the download XML r=agashlin
https://hg.mozilla.org/integration/autoland/rev/772c8a4a58ae
Allow the update agent to link against updatecommon r=glandium
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.