1627805 - Enable update agent to get the update directory path

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Robin Steuber (she/her) [:bytesized]]

The update agent will need access to the update directory for its instance of Firefox. A complicating factor is that the update directory, if it doesn't exist, absolutely must be created with the correct permissions (which is currently done by the update directory path generation function). This means that, ideally, we shouldn't duplicate this functionality, but should instead reuse or, if necessary, rewrite the existing functionality.

The functionality currently lives here. It doesn't use any XUL code, but it is written in C++, which makes it difficult to link to from Rust.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1627805 - Obtain path for the download XML r=agashlin

Comment 2

[Robin Steuber (she/her) [:bytesized]]

I've posted a patch that almost works. It builds updatecommon.lib, and links the update agent to it. Unfortunately, the two things are not properly linked in the dependency graph, so I believe that whether or not ./mach build builds on the first try ends up being a race condition.

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1627805 - Allow the update agent to link against updatecommon r=glandium

The update agent links against updatecommon (/toolkit/mozapps/update/common), but it does so in a mechanism that our build system doesn't actually support. This patch ensures that the updatecommon library will be built before the update agent, so that the update agent can link successfully.

Depends on D69875

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fde1306bba7
Obtain path for the download XML r=agashlin
https://hg.mozilla.org/integration/autoland/rev/772c8a4a58ae
Allow the update agent to link against updatecommon r=glandium

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8fde1306bba7
https://hg.mozilla.org/mozilla-central/rev/772c8a4a58ae