1628014 - Make Allocate functions call constructors

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco) (PTO until 2nd March)]

Right now to allocate a GC thing you do something like:

  JSFooThing* foo = Allocate<JSFooThing>(cx);
  new (foo) JSFooThing(some, args);

It would be more idiomatic to pass the constructor argument through Allocate, like this:

  JSFooThing* foo = Allocate<JSFooThing>(cx, some, args);

In some cases we don't call a constructor at all, and that may be undefined behaviour depending on the class itself. Always calling a constructor would prevent this possibility.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1628014 - Add typed Cell::NewCell<T>() and cx->newCell<T>() methods

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1628014 - Expand NewCell to cover strings, BigInt, and objects

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1628014 - Replace StringT::emplace() methods with direct calls to constructor (from a friend struct).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34625c0ebf21
Add typed Cell::NewCell<T>() and cx->newCell<T>() methods r=jonco,tcampbell
https://hg.mozilla.org/integration/autoland/rev/6952a8524c26
Replace StringT::emplace() methods with direct calls to constructor (from a friend struct). r=arai

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/34625c0ebf21
https://hg.mozilla.org/mozilla-central/rev/6952a8524c26