1628053 - [Fission] Find in page says strings are found when they are not, highlights incomplete strings

Status: VERIFIED FIXED

(Core :: Find Backend, defect, P3)

Description

[Asif Youssuff]

Attachment: Screencast from 04-07-2020 02:14:14 PM.webm

Steps to reproduce:

1. Visit https://old.reddit.com/r/firefox/comments/fvto5t/popups_history_deletion_file_downloads_cookie/
2. Do Ctrl-f
3. enable "Highlight All"
4. Type ap
5. type z (making the string to be found apz).

What happens:

ap on the page is highlighted. The findbar reports that there is "1 out of 5" matches.

Expected result:

apz doesn't appear on the page, so nothing on page should be highlighted. Unfound string also had a "beep" sound previously that I no longer hear.

40:43.73 INFO: No more integration revisions, bisection finished.
40:43.73 INFO: Last good revision: bb19bd67310fd0f0b309759d530ce6292b42d16e
40:43.73 INFO: First bad revision: 59baad4b26ee099e2a8f4e79d973e5d4549a95c6
40:43.73 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bb19bd67310fd0f0b309759d530ce6292b42d16e&tochange=59baad4b26ee099e2a8f4e79d973e5d4549a95c6

Comment 1

[Asif Youssuff]

tetsuharu, can you look at this? Your patch seems to have caused this regression. Thanks!

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

This is reproducible on

• https://hg.mozilla.org/mozilla-central/rev/93bdbca5399c12b3eec5f03bbc323e00f7ef3a51
• macOS 10.15.4 (19E287)
• fission.autostart=true

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

When I open findbar with Ctrl+F, SecurityError: Permission denied to access property "addEventListener" on cross-origin object 8 Finder.jsm:58 is shown in Browser Console

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Tetsuharu OHZEKI [:tetsuharu] (UTC+9) from comment #3)

When I open findbar with Ctrl+F, SecurityError: Permission denied to access property "addEventListener" on cross-origin object 8 Finder.jsm:58 is shown in Browser Console

This only happens in fission window.

Comment 5

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Tetsuharu OHZEKI [:tetsuharu] (UTC+9) from comment #4)

(In reply to Tetsuharu OHZEKI [:tetsuharu] (UTC+9) from comment #3)

When I open findbar with Ctrl+F, SecurityError: Permission denied to access property "addEventListener" on cross-origin object 8 Finder.jsm:58 is shown in Browser Console

This only happens in fission window.

This might not be related to this. But I confirm this bug is only reproducible with enabling fission.
On Non-Fission window, this works right.

Comment 6

[Chris Peterson [:cpeterson]]

Neil, are you working on find-in-page bugs for Fission?

Tracking for Fission Nightly (M6) milestone

Comment 7

[Neil Deakin]

Attachment: Bug 1628053, don't get the root window when adding the unload listener, r=mikedeboer

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fabe539cdc5e
don't get the root window when adding the unload listener, r=mikedeboer

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fabe539cdc5e

Comment 10

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue using Firefox 77.0a1 (20200407214402) on Windows 10x64.
The issue is verified fixed using Firefox 78.0a1 (20200511214706) from comment 9 on Windows 10x64.