1628117 - Reduce `BrowserApp` usage in mobile code

Status: RESOLVED FIXED

(GeckoView :: Extensions, task, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

There is a lot of left-over code from Fennec that uses BrowserApp. This is bad for two reasons:

• Some of this code doesn't work at all, and causes weird bugs
• Offers bad examples to developers, since we don't want people to use it.

I had some downtime so I removed some of it. Patch incoming.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1628117 - Remove fennec code from descriptors/tabs.js.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1628117 - Reduce use of BrowserTab in mobile code.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1628117 - Add window.tab.

This will replace all current uses of BrowserApp..

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1628117 - Remove BrowserApp.tabs.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1628117 - Remove fennec code from marionette.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1628117 - Remove BrowserApp.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63b977732075
Remove fennec code from descriptors/tabs.js. r=jdescottes,snorp
https://hg.mozilla.org/integration/autoland/rev/30116ea848c7
Reduce use of BrowserTab in mobile code. r=mixedpuppy,snorp
https://hg.mozilla.org/integration/autoland/rev/a0508a8f0733
Add window.tab. r=snorp
https://hg.mozilla.org/integration/autoland/rev/12827a9f8ed2
Remove BrowserApp.tabs. r=lina,snorp
https://hg.mozilla.org/integration/autoland/rev/d867e385620f
Remove fennec code from marionette. r=snorp,whimboo
https://hg.mozilla.org/integration/autoland/rev/6319076b66d6
Remove BrowserApp. r=snorp

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a577a05a63d5
Backed out 6 changesets for causing Marionette failures.

Comment 9

[Alexandru Michis [:malexandru]]

Backed out 6 changesets for causing Marionette failures. (and other failures)

Backout link: https://hg.mozilla.org/integration/autoland/rev/a577a05a63d5d9fc7910a7b2d95d2ba576ca93b1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=b808c96379c4797772b44a5a8e265f46faac9637&fromchange=6319076b66d6264a90bd2aecbdb816dbe4345abc&failure_classification_id=2&selectedJob=297563932

Failure logs:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297562269&repo=autoland&lineNumber=1309
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297562171&repo=autoland&lineNumber=1587
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297560595&repo=autoland&lineNumber=1490
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297562749&repo=autoland&lineNumber=695
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297565926&repo=autoland&lineNumber=1256
• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297560576&repo=autoland&lineNumber=1593

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61dd288e5a93
Remove fennec code from descriptors/tabs.js. r=jdescottes,snorp
https://hg.mozilla.org/integration/autoland/rev/b63ccf47e962
Reduce use of BrowserTab in mobile code. r=mixedpuppy,snorp
https://hg.mozilla.org/integration/autoland/rev/63f298ddc3a3
Add window.tab. r=snorp
https://hg.mozilla.org/integration/autoland/rev/b5e21bc93d87
Remove BrowserApp.tabs. r=lina,snorp
https://hg.mozilla.org/integration/autoland/rev/b709aea6f97d
Remove fennec code from marionette. r=snorp,whimboo
https://hg.mozilla.org/integration/autoland/rev/1d023109d9df
Remove BrowserApp. r=snorp

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/61dd288e5a93
https://hg.mozilla.org/mozilla-central/rev/b63ccf47e962
https://hg.mozilla.org/mozilla-central/rev/63f298ddc3a3
https://hg.mozilla.org/mozilla-central/rev/b5e21bc93d87
https://hg.mozilla.org/mozilla-central/rev/b709aea6f97d
https://hg.mozilla.org/mozilla-central/rev/1d023109d9df