1628236 - VoiceOver speaks wrong column number for cells following one that has a col span > 1

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

After bug 1618705, VoiceOver now announces the number of columns in a table. However, when traversing a table, and a column has a cell with a col span, the next cells within that row get their column number read wrong.

STR:

1. Open this test page.
2. With VoiceOver on, focus the first table.
   • Result: VoiceOver says that the table has 8 rows and 11 columns.
3. Press CTRL+Option+RightArrow.
   • Result: You land on the JAWS column header, and VoiceOver says "Column 2, row 1, spans 3 columns".
4. Press CTRL+Option+RightArrow again.
   • Expected: VoiceOver speaks Narrator, "Column 5, row 1". This is consistent with what it speaks in Safari.
   • Actual: VoiceOver says "Narrator", followed by "Column 3, row 1".
5. The same can be observed traversing to the NVDA column header, which spans 2 columns. The last column is Column 8 of 11, before moving to row 2 column 1. It should be column 11 of 11.

Comment 1

[Morgan Reschenberg [:morgan]]

Distilled test case here:
data:text/html, <table><tr><th colspan="2">Header 1</th><th>Header 2</th></tr></table>

Voiceover reports the second header as the second column despite the first header spanning two columns. Spans should offset later column indicies. Will fix :)

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1628236 - Add cell getter and column headers attribute to tables. r?morgan

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a83d85107142
Add cell getter and column headers attribute to tables. r=morgan

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset a83d85107142 (bug 1628236) for OSX build bustage on mozTableAccessible.h. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310598083&repo=autoland&lineNumber=9424

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=a83d85107142b112d5bb09514d5bcb90c82821cc

Backout:
https://hg.mozilla.org/integration/autoland/rev/ebadeb7a9493b4fec2cac9ba53be7d7b14975368

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/000d62ec9b5c
Add cell getter and column headers attribute to tables. r=morgan

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/000d62ec9b5c

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly from 2020-04-08, verified that the issue is fixed using latest Firefox 80.0b5 on macOS 10.15.6.