Closed Bug 1628372 Opened 6 months ago Closed 5 months ago

Hide sync button from customizeToolbar code

Categories

(SeaMonkey :: Sync UI, defect)

defect
Not set
normal

Tracking

(seamonkey2.53 affected, seamonkey2.57esr affected)

RESOLVED FIXED
seamonkey 2.74
Tracking Status
seamonkey2.53 --- affected
seamonkey2.57esr --- affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Regression)

Details

Attachments

(1 file)

At the moment, even though there's no icon/text, the sync button is still available as blank icon when a user customises their toolbar in browser or mailnews.

[Approval Request Comment]
Regression caused by (bug #): 1432273
User impact if declined: ghost icon in customise toolbar dialog
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9139181 - Flags: review?(frgrahl)
Attachment #9139181 - Flags: approval-comm-release?
Attachment #9139181 - Flags: approval-comm-esr60?
Comment on attachment 9139181 [details] [diff] [review]
Properly hide sync button

LGTM 2.53.3 or 2.53.2 final?
Attachment #9139181 - Flags: review?(frgrahl)
Attachment #9139181 - Flags: review+
Attachment #9139181 - Flags: approval-comm-release?
Attachment #9139181 - Flags: approval-comm-release+
Attachment #9139181 - Flags: approval-comm-esr60?
Attachment #9139181 - Flags: approval-comm-esr60+

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

Comment on attachment 9139181 [details] [diff] [review]
Properly hide sync button

LGTM 2.53.3 or 2.53.2 final?

It would be nice to go into 2.53.2 final but not essential

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/5348c023ec15
Hide sync button from customizeToolbar code. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Scheduled for 2.53.2 Final

Target Milestone: --- → seamonkey 2.74
You need to log in before you can comment on or make changes to this bug.