Closed Bug 1432273 Opened 2 years ago Closed 2 years ago

Disable Sync UI in SeaMonkey until sync is fixed

Categories

(SeaMonkey :: Sync UI, defect)

defect
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey2.57
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Keywords: user-doc-needed)

Attachments

(2 files)

It is no longer possible to set up a sync 1.1 server for use with SeaMonkey. The code has been removed from toolkit. As a (hopefully) temporary measure till sync 1.5 can be ported the sync ui needs to be disabled as discussed in a previous status meeting.

+++ This bug was initially created as a clone of Bug #998807 +++

(Quoting rsx11m from bug 993847 comment #15)
> I've created the Sync account with a Firefox release build (which worked
> flawlessly) and then tried to connect SeaMonkey trunk by pairing with that
> 3-group/4-character key. This gave me the following:
> 
> Error: [Exception... "basicPassword setter should be not used in
> BrowserIDManager'basicPassword setter should be not used in
> BrowserIDManager' when calling method: [nsIRunnable::run]"  nsresult:
> "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "native frame ::
> <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]

This still works in 2.25 but is broken in current nightly builds.
...
Attachment #8944522 - Flags: review?(iann_bugzilla)
What about those who still have Sync working with their own server? Sync 1.1 still works as of 2.49.1, if it was set up in a previous version (2.25?).
The sync 1.1 code has been removed by Mozilla so this will no longer work in later versions. The 2.49.x line will not be changed e.g. the code will be kept in. 

The plan is to eventually set up our own 1.1 server and put the removed code back in or port 1.5 but we currently don't have the resources to do this and need to fix breakage over breakage first because of changes in the Mozilla tree. Volunteers with programming experience welcome or this will take some time.
Summary: Disable Sync UI in SeaMonkey until syn is fixed → Disable Sync UI in SeaMonkey until sync is fixed
Comment on attachment 8944522 [details] [diff] [review]
1432273-disablesyncui.patch

Probably the best route, unfortunately r=me
Attachment #8944522 - Flags: review?(iann_bugzilla) → review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/74a79ba18974
Disable sync and its ui in SeaMonkey until sync 1.5 is ported. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Attached patch manifest.diffSplinter Review
Should have done a clobber build. Patch from Bill for the bustage and r+
Attachment #8948363 - Flags: review+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/63f09d10244c
Remove services-sync.js from package-manifest. r=frg
Blocks: 1436257
Target Milestone: --- → Seamonkey2.57
Odd little side-note,apparently my Bugzilla account, which was like 16 years old, got deleted and I was required to enter a ludicrous long password to get back in. Anyway..

Frank, can you give us a bit of clarification? Does fixed mean the old code has simply been erased from the core, or does it mean that the new Sync code has been patched in to place? <crosses fingers>

Can you link me to the correct thread for the new code for the new Sync function being added? I'm currently installing WinXP virtual machines, and desperately need some sort of working solution. I can't even find a patch or add-on or anything to get around the lack of a working feature.
Flags: needinfo?(frgrahl)
Disable just means disable. Frontend code is still there but not bundled. Sync is essentially dead in current SeaMonkey versions. Sync 1.1 code has been removed from Gecko. Porting Sync 1.5 needs someone who will do it and the remaining current devs have their hands full so this is on the backburner.

Porting 1.5 is tracked in bug 998807. But because 1.5 is tightly integrated into the Mozilla infrastructure and we are essentially moving away from it a better approach might be to just make 1.1 work again in suite and set up a 1.1 server. Either way needs someone to do it so it is essentially in limbo for now which means no Sync :(
Flags: needinfo?(frgrahl)
(In reply to Frank-Rainer Grahl (:frg) from comment #9)
> Disable just means disable. Frontend code is still there but not bundled.
> Sync is essentially dead in current SeaMonkey versions. Sync 1.1 code has
> been removed from Gecko. Porting Sync 1.5 needs someone who will do it and
> the remaining current devs have their hands full so this is on the
> backburner.
> 
> Porting 1.5 is tracked in bug 998807. But because 1.5 is tightly integrated
> into the Mozilla infrastructure and we are essentially moving away from it a
> better approach might be to just make 1.1 work again in suite and set up a
> 1.1 server. Either way needs someone to do it so it is essentially in limbo
> for now which means no Sync :(

I agree completely, I think you've nailed it on the head. First off, I want to verify that you've left the back-end code (not GUI) for Sync 1.1 in place? The reason is that IF we try to add the code back in after a few versions, we might have some unexpected bugs popping up and causing yet more headaches. If we just comment out the GUI stuff, and leave the guts of the function in place, it will be much simpler to re-implement Sync 1.1 later, if needed

I think that the key here is that SeaMonkey needs a functioning Sync server. Well.. I read through bug 998807 and noted that the guy running Pale Moon HAS a running Sync Server. Perhaps SeaMonkey needs to be a bit more assertive and ask Mozilla for a physical (virtual?) machine to use. Then we could ask the guy running Pale Moon if he could mirror his server to set one up for SeaMonkey.. since nobody else is available to do it. It seems to me that HE is the resource that the project needs to move forward with the function at the moment. If Firefox doesn't want SeaMonkey clogging up their Sync 1.5 server anyway, I can't imagine why they wouldn't just let SeaMonkey have it's own Sync 1.1 server. Heck, I would bet money they probably (probably) just mothballed the old Sync server anyway, and installed a new one from scratch. It MIGHT be just as simple as having Firefox erase their old accounts off of the old server, and putting it back online for SeaMonkey to use. :D <crosses fingers>

..now all of this is assuming that there aren't any other bugs for Sync 1.1 that are breaking other functions in SeaMonkey. I haven't worked on Mozilla code in like a decade, so there is probably a bunch of stuff going on that I don't know about in the first place. ;)
As stated. The frontend code is still in. The 1.1 backend code in Gecko has been removed.

It is still present in 2.49 I think so you might be able to use a private 1.1 server there.

Mozilla wants SeaMonkey off their infra. TB later.

FRG
(In reply to Frank-Rainer Grahl (:frg) from comment #11)
> As stated. The frontend code is still in. The 1.1 backend code in Gecko has
> been removed.
> 
> It is still present in 2.49 I think so you might be able to use a private
> 1.1 server there.
> 
> Mozilla wants SeaMonkey off their infra. TB later.
> 
> FRG

Thank you for your patience Frank. Yes, the 1.1 Sync SHOULD be functional, with a Sync 1.1 sever, up through 2.56 I believe? At any rate, I'm more concerned about a permanent solution for the community, not for my needs. For my needs, I discovered a (less than optimal) solution to mirror my profile to a different machine. It's rather convoluted, but doable. I would hate to see a core function wither away. Also, SeaMonkey is currently the BEST security solution that Mozilla offers, I have all of my security concerns covered HERE, not the train wreck the Firefox crew is driving in to a hole.

Also, you said that MOZILLA wants SeaMonkey off of their infra..structure? Are you trying to say that Firefox doesn't want SeaMonkey end users clogging up their resources (which is rather greedy, but forgivable), or are you saying that Mozilla is abandoning and disowning SeaMonkey? ..because those are two very VERY different scenarios.

Thanks again!
See Also: → 1575489
You need to log in before you can comment on or make changes to this bug.