162858 - Correct icon not used for E-mail on XP start menu

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Malcolm Scott]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.1) Gecko/20020814
BuildID:    2002081419

The installer wizard for this build does not set the E-mail icon correctly at
the top-left of XP's start menu. This is (presumably) due to a typo. The
following registry key *should* have been set:

HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla\DefaultIcon\(Default)

But the typo means that DefaultIcon came out as "DefaultsIcon" (which is ignored
by XP). Since I was upgrading Mozilla, the old DefaultIcon entry was left intact
(i.e. the first icon in MOZILLA.EXE).

Reproducible: Didn't try

Comment 1

[Malcolm Rowe]

That would be here:
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/mail.jst#232
and here:
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/windows/mail.jst#245

Comment 2

[Malcolm Rowe]

Attachment: Patch (not tested)

Comment 3

[Malcolm Rowe]

cc'ing dprice for review (original reviewer in bug 158187).

What happens if we don't have a DefaultIcon subkey?  Does XP display the 
generic Mozilla icon, or something worse?

Comment 4

[Malcolm Scott]

If there is no DefaultIcon subkey, you are correct in saying that the default
Mozilla icon (red lizard) is displayed.

Comment 5

[Jason M. Abels]

Renaming the registry key from DefaultsIcon to DefaultIcon immediately corrects
the problem. I haven't verified if the patch does this, but I do know this will
correct the problem.

Comment 6

[Malcolm Rowe]

*** Bug 165158 has been marked as a duplicate of this bug. ***

Comment 7

[Malcolm Rowe]

Requsting r=/sr= for this trivial typo patch.
We didn't get this into 1.1.  It would be nice to fix it at some point.

Comment 8

[Henrik Gemal]

dupe of the famouse icon meta bug...

*** This bug has been marked as a duplicate of 28174 ***

Comment 9

[Malcolm Scott]

Henrik Gemal - please explain why this is a duplicate of bug 28174. That bug is
about a dialog box to specify where icons are created. This bug (which has a
patch ready!) is about a typo in the Installer when creating a registry entry.

Comment 10

[Malcolm Rowe]

What the other Malcolm said.  This isn't remotely about the shortcut select
dialog, it's a typo fix in existing installer code.

Reopening.  Sorry Henrik, you goofed here.

Comment 11

[Henrik Gemal]

sorry about that. this is not a dupe.
the fix is trivial and should land asap....

Dan: perhaps you could r or sr this simple patch?

Comment 12

[Henrik Gemal]

still need r and sr for this *VERY* simple patch

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 95419 [details] [diff] [review]
Patch (not tested)

sr=roc+moz

send email to [e-mail] to get a review.

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 95419 [details] [diff] [review]
Patch (not tested)

r=dveditz

Comment 15

[Daniel Veditz [:dveditz]]

Need me to check in for you?

Comment 16

[Malcolm Rowe]

Dan: yes please.  Thanks for the review.

Comment 17

[Malcolm Rowe]

caillon checked this in.

Marking FIXED.

Comment 18

[Grace Bush]

verified on 11/12 build

Comment 19

[Robert Morris]

Is it just me (on both of my computes), or does the Mozilla Mail icon on the
Start menu now default to the red lizard head with the triangular thing (the
exact same one used for the browser)? (For anyone new to this bug: I'm talking
about the icon that shows on the Windows XP Start menu when Mozilla Mail is
selected as the program to be displayed on the Internet/Mail section at the top.)

This should be a simple fix: instead of setting
HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla\DefaultIcon to "<Install
Path>\mozilla.exe,0" (or whatever it is now) , set it to "<Install
Path>\chrome\icons\default\messengerWindow.ico".

This is the only bug I could find that's related; I wanted to see if it's an
issue for anyone else before--if need be--filing a new bug.