1618295 - [rel=preload] Update `image::imgLoader` to use `PreloaderBase` and `Document.PreloadService`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Honza Bambas (:mayhemer)]

Part of Design documentation for rel=preload

Please follow this “image” type design.

This depends on the PreloaderBase class being implemented. The idea is to let the image load handler (imgRequest) derive from it and let the loader register it in Document.PreloadService.

Other part is to kick the preload as speculative load from inside the HTML5 parser for images.

Note that the image loader will never be called more than once to start a speculative load, neither preload or regular, so there is no need to add any more coalescing than we already have in the HTML5 parser (the caller to the loader) and the image loader itself. The image cache is the internal loader coalescing mechanism and we use it to link speculative loads and actual loads. This will not be changed.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Bug 1618295 - Make `imgRequest` implement and use `PreloaderBase` to suppoer the preload as speculative load feature, r=tnikkel

Depends on D68786

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: Bug 1618295 - Make imgRequestProxy implement and use PreloaderBase to support the preload as speculative load feature;

Depends on D68786

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79f96395bcfaab890e12b5f9c99a19c348f57b02

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to Edgar Chen [:edgar] from comment #4)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79f96395bcfaab890e12b5f9c99a19c348f57b02

There will be a lot of failures from the surrounding preload changes too. I'm right now working on cleaning the crashes up along with rebasing of the patches + incorporating your latest patch too. Edit: no, just everything before with preload disabled (at current default).

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1618295 - Add imageSrcset and imageSizes attributes in HTMLLinkElement;

See https://html.spec.whatwg.org/multipage/semantics.html#htmllinkelement.

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1618295 - Add imagesrcset and imagesizes attribute to the HTML parser;

See https://html.spec.whatwg.org/multipage/semantics.html#the-link-element:attr-link-imagesrcset.

Depends on D71949

Comment 8

[Timothy Nikkel (:tnikkel)]

I filed bug 1635599 for the existing issue with MaybePreLoadImage and IsImageInCache.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13350bb8d726
Add imageSrcset and imageSizes attributes in HTMLLinkElement; r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/9ea0dc474630
Add imagesrcset and imagesizes attribute to the HTML parser; r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/91163f65e128
Make imgRequestProxy implement and use PreloaderBase to support the preload as speculative load feature; r=tnikkel,smaug,mayhemer

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/13350bb8d726
https://hg.mozilla.org/mozilla-central/rev/9ea0dc474630
https://hg.mozilla.org/mozilla-central/rev/91163f65e128

Comment 12

[Henri Sivonen (:hsivonen)]

https://github.com/validator/htmlparser/commit/2402c32bb4e5a13d5d8a045a47f8095605dd6535