1628799 - Remove unused / duplicate entities from imported editor locale files

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Description

[Ian Neal]

When bug 1571687 landed, there was some duplication created between entities in the existing messengercompose locale files and the ones imported from editor.

Comment 1

[Ian Neal]

Attachment: Remove unused / duplicate entities - Part 1

As far as I can see most of these are duplicated entities, the only ones that I believe are unused are pasteAs.label/accesskey:
https://searchfox.org/comm-central/search?q=pasteAs.&case=false&regexp=false&path=

I would just consider this as part of the fix, there may be other files too but I don't have the time to look through it all. Perhaps if there are can they can be spun off into separate bugs.

Comment 2

[Ian Neal]

The pasteAs.label/accesskey seemed to have stopped being used somewhere between mozilla 1.8 and mozilla 1.9 releases (14ish years ago).

Comment 3

[Khushil Mistry [:khushil324]]

Comment on attachment 9139539 [details] [diff] [review]
Remove unused / duplicate entities - Part 1

Thanks! Looks good to me. I will look into other files of /messengercompose in another bug.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9139539 [details] [diff] [review]
Remove unused / duplicate entities - Part 1

Review of attachment 9139539 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f44b29f8b4f
Remove unused / duplicate entities from imported editor locale files. r=mkmelin DONTBUILD