1628907 - Restart to update popup is still visible after moving to a different workspace

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Danny Colin [:sdk]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

1. Wait for the "Restart to update" popup to appear but don't interact with it
2. Change to another workspace on my Linux* desktop

• WM: bspwm
• OS: Fedora 31

Actual results:

The popup is still visible.

Expected results:

The popup should stay on the same workspace as Thunderbird is.

Comment 1

[Richard Marti (:Paenglab)]

Danny, on a displayed message in the message header are the From and To addresses. Can you click on the star? Then a popup should open. When it's open, change to another workspace. Does this popup act the same as the update popup? If yes, you could try in Firefox the bookmarks popup and do the same. If they all act the same it's a toolkit issue on the popups.

Comment 2

[Danny Colin [:sdk]]

(In reply to Richard Marti (:Paenglab) from comment #1)

Does this popup act the same as the update popup? If yes, you could try in Firefox the bookmarks popup and do the same. If they all act the same it's a toolkit issue on the popups.

No, this one works as expected. And the strange thing is that Firefox Nightly has a similar update popup that also works.

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[Wayne Mery (:wsmwk)]

Danny, did this happen prior 77, in 68?

Comment 5

[Danny Colin [:sdk]]

Danny, did this happen prior 77, in 68?

I don't think I had this issue with 68 but I could be wrong. I mean use Nightly has my main Thunderbird so it feels like 68 was released a decade ago :).

Comment 6

[kumar]

Same thing happens with "Update available" notification window, they are visible across different applications window.

In GNOME, when I switch between applications Thunderbird's "update available" notification window overlaps with other applications window. I'm attaching a screenshot of Firefox window overlapped with TB's "update available" notification window.

Comment 7

[kumar]

Attachment: Firefox window overlapped with TB's "Update available" notification window

Comment 8

[WaltS48 [:walts48]]

I can confirm the issue using Daily 96.0a1 on Fedora 35 Workstation, Gnome 41 desktop.

Got the update prompt when I opened Daily.
Switched to the 2nd workspace, and it was the only item showing.
Selected Firefox in the first workspace and saw the prompt as per comment 7.

Comment 9

[Danny Colin [:sdk]]

Hey :stransky,

Since you recently worked on other popup related issue on Firefox, would you have any idea what could be the cause of this problem?

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Is that Wayland or X11 backend?

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Also is there any testcase available for Firefox? How is the popup opened?

Comment 12

[Danny Colin [:sdk]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #10)

Is that Wayland or X11 backend?

I use X11 but I haven't tested on Wayland so I can't tell if the issue is also present on it.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #11)

Also is there any testcase available for Firefox? How is the popup opened?

ni? :Paenglad for that.

Comment 13

[Richard Marti (:Paenglab)]

This was added by Geoff in bug 1496632. So better ask him.

Comment 14

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

I know how to fix this now.

Comment 15

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Attachment: Bug 1628907 - Make the global notifications popup not an arrow panel. r=Paenglab

Removing the attribute fixes the problem but also means we lose the styling, so I've copied the relevant styles.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c390bb1b7603
Make the global notifications popup not an arrow panel. r=Paenglab

Comment 17

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Comment on attachment 9284427 [details]
Bug 1628907 - Make the global notifications popup not an arrow panel. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Update pop-up more annoying than necessary, it's been this way for an age though
Testing completed (on c-c, etc.): A week
Risk to taking this patch (and alternatives if risky): No, just some style changes

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9284427 [details]
Bug 1628907 - Make the global notifications popup not an arrow panel. r=Paenglab

[Triage Comment]
Approved for beta

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 103.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/dd4f584369a0

Comment 20

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

Comment on attachment 9284427 [details]
Bug 1628907 - Make the global notifications popup not an arrow panel. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Update pop-up more annoying than necessary, it's been this way for an age though
Testing completed (on c-c, etc.): In 103 b6
Risk to taking this patch (and alternatives if risky): No, just some style changes

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9284427 [details]
Bug 1628907 - Make the global notifications popup not an arrow panel. r=Paenglab

[Triage Comment]
Approved for esr102

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/3a846aa400c2