Ctrl+Enter / Ctrl+Shift+Enter keyboard shortcuts for sending message no longer work from recipient input
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(Not tracked)
People
(Reporter: thomas8, Assigned: thomas8)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.06 KB,
patch
|
thomas8
:
review+
|
Details | Diff | Splinter Review |
Ctrl+[Shift]+Enter no longer works when focus is in recipient input.
Assignee | ||
Comment 1•5 years ago
|
||
Simple fix.
Assignee | ||
Comment 2•5 years ago
|
||
I removed event.stopPropagation(); event.preventDefault();
because they don't seem to do anything (on Windows at least). Alex might know more.
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #3)
Review of attachment 9139846 [details] [diff] [review]:
Looks good, thanks for fixing this.
I'm here to help, thanks for the review.
Can you please update the commit message with:
"Bug 1629144 - Restore Ctrl+Enter/Ctrl+Shift+Enter behaviour when an
addressing row is focused. r=aleca"
Done.
Alex, pls set tb-checkin-needed as appropriate. Does this need a try-run? Would you want to add a test?
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/5d4c12618d3f
Restore Ctrl+Enter/Ctrl+Shift+Enter behaviour when an addressing row is focused. r=aleca
Comment 7•5 years ago
|
||
This caused a regression which moves the cursors to the next input field when a pill is created
Comment 8•5 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #7)
This caused a regression which moves the cursors to the next input field when a pill is created
Upon further investigation, the regression wasn't cause by this bug but rather by the changes done in the toolkit autocomplete in bug 1627520.
I'll see if I can fix it.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 9•4 years ago
|
||
We improved this in bug 1663583 to also allow Cmd+Enter for sending the message.
Comment 10•4 years ago
|
||
Hi,
After a quick check, it seems the bug is fixed here, i.e. ctrl-enter now works from the To and Subject fields.
Thanks!
Best regards
Description
•