1629144 - Ctrl+Enter / Ctrl+Shift+Enter keyboard shortcuts for sending message no longer work from recipient input

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

Ctrl+[Shift]+Enter no longer works when focus is in recipient input.

Comment 1

[Thomas D. (:thomas8)]

Attachment: ctrlEnterRecipientInput.diff

Simple fix.

Comment 2

[Thomas D. (:thomas8)]

I removed event.stopPropagation(); event.preventDefault(); because they don't seem to do anything (on Windows at least). Alex might know more.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9139846 [details] [diff] [review]
ctrlEnterRecipientInput.diff

Review of attachment 9139846 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for fixing this.
The preventDefault was initially implemented to avoid triggering the send message when pressing enter.
Listening for the Control key modifier is a better approach.

Can you please update the commit message with:
"Bug 1629144 - Restore Ctrl+Enter/Ctrl+Shift+Enter behaviour when an addressing row is focused. r=aleca"

Comment 4

[Thomas D. (:thomas8)]

Attachment: 1629144_ctrlEnterRecipientInput.diff

(In reply to Alessandro Castellani (:aleca) from comment #3)

Review of attachment 9139846 [details] [diff] [review]:
Looks good, thanks for fixing this.

I'm here to help, thanks for the review.

Can you please update the commit message with:
"Bug 1629144 - Restore Ctrl+Enter/Ctrl+Shift+Enter behaviour when an
addressing row is focused. r=aleca"

Done.

Alex, pls set tb-checkin-needed as appropriate. Does this need a try-run? Would you want to add a test?

Comment 5

[Alessandro Castellani [:aleca]]

Try run launched: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a3909be1a5fc3882252a0d29b84058fdf79c775f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d4c12618d3f
Restore Ctrl+Enter/Ctrl+Shift+Enter behaviour when an addressing row is focused. r=aleca

Comment 7

[Alessandro Castellani [:aleca]]

This caused a regression which moves the cursors to the next input field when a pill is created

Comment 8

[Alessandro Castellani [:aleca]]

(In reply to Alessandro Castellani (:aleca) from comment #7)

This caused a regression which moves the cursors to the next input field when a pill is created

Upon further investigation, the regression wasn't cause by this bug but rather by the changes done in the toolkit autocomplete in bug 1627520.
I'll see if I can fix it.

Comment 9

[Thomas D. (:thomas8)]

We improved this in bug 1663583 to also allow Cmd+Enter for sending the message.

Comment 10

[Jean-Philippe MENGUAL]

Hi,

After a quick check, it seems the bug is fixed here, i.e. ctrl-enter now works from the To and Subject fields.

Thanks!

Best regards