162917 - Initial focus problems with sheets

Status: RESOLVED WONTFIX

(Core :: XUL, defect, P5)

Description

[Brian Ryner (not reading)]

When a sheet comes up, we often don't end up with the correct active widget on
the nsMacEventHandler object, which means that key events don't get dispatched
correctly.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Carried over from bugscape bug 19001, patch from sfraser.

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 95451 [details] [diff] [review]
patch

carrying over r=sdagley, sr=bryner from bugscape 19001.

Comment 3

[Brian Ryner (not reading)]

carrying over ADT status from bugscape 19001; adding mozilla1.0.1 for drivers.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 95451 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.0.1

Comment 5

[Brian Ryner (not reading)]

checked in on the trunk and 1.0 branch.

Comment 6

[Robert John Churchill]

*** Bug 142754 has been marked as a duplicate of this bug. ***

Comment 7

[Greg K.]

*** Bug 134574 has been marked as a duplicate of this bug. ***

Comment 8

[Jaime Rodriguez, Jr.]

jrgm: can you pls verify this as fixed on the 1.0 branch, then replace
"fixed1.0.1" with "verified1.0.1"? Thanks!

Comment 9

[Bill McGonigle (not currently reading bugmail; please contact directly)]

This doesn't seem to be fixed in all cases. 

Test: 
set prefs...privacy...ssl..."leaving a page that supports encryption"
go to an https: site, e.g. https://sourceforge.net
go to an http site, e.g. http://www.mozilla.org

expected results: sheet comes down, hit return to dismiss dialog
actual results: key stroke not focused on sheet

tested on 1.2.1: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.2.1)
Gecko/20021130

Comment 10

[Jonathan Brecher]

I think the previous comment that caused this to become reopened is a dup of bug 
160630 ?

Comment 11

[Bill McGonigle (not currently reading bugmail; please contact directly)]

bug 160630 seems to be about keyevent buffering.  The problem I'm seeing is
sheet focus.  It doesn't matter when you hit enter, the sheet isn't dismissed. 
Different unless I'm missing something.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Decreasing the priority as no update for the last 2 years on this bug.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage 
about the priority meaning.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 14

[Neil Deakin]

This is out of date.