Closed Bug 1629424 Opened 3 months ago Closed 2 months ago

nsSHistory.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: Sylvestre, Assigned: kel42, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file, 1 obsolete file)

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/docshell/shistory/nsSHistory.cpp#1363

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Summary: LayerManagerMLGPU.cpp: redundant return statement at the end of a function with a void return type → nsSHistory.cpp: redundant return statement at the end of a function with a void return type
Assignee: nobody → kel42
Status: NEW → ASSIGNED
Attachment #9145351 - Attachment is obsolete: true
Attachment #9145184 - Attachment description: Bug 1629424 - remove useless return. Sylvestre → Bug 1629424 - remove useless return. r?sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76a4a3b72925
remove useless return. r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.