1629423 - LayerManagerMLGPU.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1613255 +++

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/gfx/layers/mlgpu/LayerManagerMLGPU.cpp#215

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Also, please only work on two max of such bugs.

Comment 1

[Tilden Windsor [:A-NEUN]]

Attachment: Bug 1629423 - Removed redundant return statement in function with void return type. r=sylvestre

Comment 2

[Tilden Windsor [:A-NEUN]]

I have submitted a patch for this bug.
Have I done everything correctly?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97b420971bf9
Removed redundant return statement in function with void return type. r=sylvestre

Comment 4

[Tilden Windsor [:A-NEUN]]

One more thing, would you be able to vouch for my request for level one commit access? I think it would be very useful.
Thanks!

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/97b420971bf9