1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

The changes to tests in https://hg.mozilla.org/mozilla-central/rev/1d7b14496648653222e010e2568cf24d6051cc11 has caused them all to fail in Thunderbird. They're failing because the built-in permission from mail/app/permissions exists when the test checks that no permissions exist. For some reason in Thunderbird the permissions manager is initialised very early on, whereas I suspect it is not in Firefox. (I'm trying to prove this now, but waiting for a build.)

Comment 1

[Geoff Lankow (:darktrojan)]

Hmm, no. Firefox calls PermissionManager::Init at least as early as Thunderbird does. I have run out of ideas at this point.

Comment 3

[Magnus Melin [:mkmelin]]

Firefox tests sadly do not run with the Firefox profile, while Thunderbird does (bug 1168178).
I suspect the problem is that permissions.manager.defaultsUrl "" is not working in the new setup, but would have to check exactly why.

Comment 4

[Intermittent Failures Robot]

15 failures in 4823 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 15

Platform breakdown:

• windows7-32: 2
• macosx1014-64: 2
• linux32: 2
• windows10-64: 2
• linux64: 2
• linux64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-shippable: 1
• linux32-shippable: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1629450&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku

After bug 1363541 the calls to Services.prefs.setCharPref("permissions.manager.defaultsUrl", ""); must be done early to have any effect. Otherwise the defaults will already be imported and tests do not get the expected starting point.

Comment 6

[Intermittent Failures Robot]

38 failures in 500 pushes (0.076 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 38

Platform breakdown:

• windows10-64: 6
• linux64: 6
• macosx1014-64: 6
• windows7-32: 6
• linux32: 9
• windows7-32-shippable: 1
• linux32-shippable: 1
• linux64-shippable: 1
• windows10-64-shippable: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1629450&startday=2020-04-13&endday=2020-04-13&tree=all

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a382667c78
Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/91a382667c78

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: Bug 1629450 - reset built-in permissions earily also in test_permmanager_load_invalid_entries.js. r=baku

Started failing following https://hg.mozilla.org/mozilla-central/rev/f1d9689ea300

Comment 10

[Intermittent Failures Robot]

50 failures in 1019 pushes (0.049 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 50

Platform breakdown:

• windows10-64: 9
• linux32: 9
• macosx1014-64: 9
• linux64: 9
• windows7-32: 9
• linux32-shippable: 1
• macosx1014-64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-shippable: 1
• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1629450&startday=2020-04-14&endday=2020-04-14&tree=all

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95238d08fad2
reset built-in permissions earily also in test_permmanager_load_invalid_entries.js. r=baku

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/95238d08fad2

Comment 13

[Intermittent Failures Robot]

102 failures in 4528 pushes (0.023 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 102

Platform breakdown:

• windows10-64: 17
• linux64: 17
• macosx1014-64: 17
• windows7-32: 17
• linux32: 20
• windows7-32-shippable: 2
• linux32-shippable: 3
• linux64-shippable: 3
• windows10-64-shippable: 3
• macosx1014-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1629450&startday=2020-04-13&endday=2020-04-19&tree=all