Closed Bug 1629495 Opened 6 months ago Closed 5 months ago

Mochitest debug assertion failure: !mNext (Must be unlinked), at /builds/worker/checkouts/gecko/js/xpconnect/src/xpcprivate.h:266

Categories

(Thunderbird :: General, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

(Keywords: leave-open, Whiteboard: [thunderbird-disabled-test])

Attachments

(1 file)

Example log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297341200&repo=comm-central&lineNumber=27977

I've so far narrowed it down to: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=82d84da94d8dfcb8bf0cca8d569d8daa9cc9cb73&tochange=06ee15775ba8511ff1784027c7bfde2fc7

The failing test directories are calendar/test/browser/preferences, mail/test/browser/addrbook and mail/test/browser/pref-window. Two of these involve the preferences tab. One does not.

That's set off from mozilla::intl::Localization::~Localization(). Maybe the last part of bug 1629275 will clear it up - let's see - just landed it.

Tentatively marking as WFM as it doesn't show on that run.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → WORKSFORME

Nope, still there.

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Keywords: leave-open
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/20d8e8925329
Disable four failing tests on debug. rs=bustage-fix

I've disabled the tests. AFAICT there's some weird interaction going on between the modern L10n stuff and the ancient Mozmill stuff. Fortunately all of the tests in question are ones I've been meaning to redo without Mozmill.

Whiteboard: [thunderbird-disabled-test]

Here's a rewrite of two of the tests I turned off earlier. They now have no problem with this bug.

Assignee: nobody → geoff
Status: REOPENED → ASSIGNED
Attachment #9140338 - Flags: review?(paul)
Comment on attachment 9140338 [details] [diff] [review]
1629495-calendar-preference-tests-1.diff

Review of attachment 9140338 [details] [diff] [review]:
-----------------------------------------------------------------

One little nit.  The tests passed locally for me and the code looks good.  Yay for less mozmill!

::: calendar/test/browser/preferences/browser_categoryColors.js
@@ +25,5 @@
> +    await BrowserTestUtils.waitForEvent(subDialogBrowser, "load");
> +  }
> +  await new Promise(subDialogBrowser.contentWindow.setTimeout);
> +  let subDialogDocument = subDialogBrowser.contentDocument;
> +  subDialogDocument.getElementById("categoryName").value = "ZZZ Mozmill";

Just for good measure, let's remove this "mozmill" string while we're at it (here and below).
Attachment #9140338 - Flags: review?(paul) → review+
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/54177446b7cd
Rewrite calendar preferences tests without Mozmill. r=pmorris

Calling this fixed. The other two tests can just remain disabled on debug for now.

Status: ASSIGNED → RESOLVED
Closed: 6 months ago5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 77.0
You need to log in before you can comment on or make changes to this bug.