1629495 - Mochitest debug assertion failure: !mNext (Must be unlinked), at /builds/worker/checkouts/gecko/js/xpconnect/src/xpcprivate.h:266

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

Example log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297341200&repo=comm-central&lineNumber=27977

I've so far narrowed it down to: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=82d84da94d8dfcb8bf0cca8d569d8daa9cc9cb73&tochange=06ee15775ba8511ff1784027c7bfde2fc7

The failing test directories are calendar/test/browser/preferences, mail/test/browser/addrbook and mail/test/browser/pref-window. Two of these involve the preferences tab. One does not.

Comment 1

[Magnus Melin [:mkmelin]]

That's set off from mozilla::intl::Localization::~Localization(). Maybe the last part of bug 1629275 will clear it up - let's see - just landed it.

Comment 2

[Magnus Melin [:mkmelin]]

Tentatively marking as WFM as it doesn't show on that run.

Comment 3

[Magnus Melin [:mkmelin]]

Nope, still there.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/20d8e8925329
Disable four failing tests on debug. rs=bustage-fix

Comment 5

[Geoff Lankow (:darktrojan)]

I've disabled the tests. AFAICT there's some weird interaction going on between the modern L10n stuff and the ancient Mozmill stuff. Fortunately all of the tests in question are ones I've been meaning to redo without Mozmill.

Comment 6

[Intermittent Failures Robot]

23 failures in 500 pushes (0.046 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 23

Platform breakdown:

• windows10-64: 5
• linux64: 6
• windows7-32: 5
• macosx1014-64: 4
• linux32: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1629495&startday=2020-04-13&endday=2020-04-13&tree=all

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1629495-calendar-preference-tests-1.diff

Here's a rewrite of two of the tests I turned off earlier. They now have no problem with this bug.

Comment 8

[Paul Morris [:pmorris]]

Comment on attachment 9140338 [details] [diff] [review]
1629495-calendar-preference-tests-1.diff

Review of attachment 9140338 [details] [diff] [review]:
-----------------------------------------------------------------

One little nit.  The tests passed locally for me and the code looks good.  Yay for less mozmill!

::: calendar/test/browser/preferences/browser_categoryColors.js
@@ +25,5 @@
> +    await BrowserTestUtils.waitForEvent(subDialogBrowser, "load");
> +  }
> +  await new Promise(subDialogBrowser.contentWindow.setTimeout);
> +  let subDialogDocument = subDialogBrowser.contentDocument;
> +  subDialogDocument.getElementById("categoryName").value = "ZZZ Mozmill";

Just for good measure, let's remove this "mozmill" string while we're at it (here and below).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/54177446b7cd
Rewrite calendar preferences tests without Mozmill. r=pmorris

Comment 10

[Intermittent Failures Robot]

23 failures in 4528 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 23

Platform breakdown:

• windows10-64: 5
• linux64: 6
• windows7-32: 5
• macosx1014-64: 4
• linux32: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1629495&startday=2020-04-13&endday=2020-04-19&tree=all

Comment 11

[Geoff Lankow (:darktrojan)]

Calling this fixed. The other two tests can just remain disabled on debug for now.