1629590 - issues with standalone page for certificate viewer

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[Sören Hentzschel]

In bug 1585620 a standalone page for the certificate viewer was implemented. But the implementation has several issues. This ticket is kind of a meta issue.

1. It takes several seconds to load the tabs. For ~ 5 seconds only the headline is visible, nothing else.
2. The caption of the first tab is "Unknown".
3. The content of the first tab is completely empty (expected state is unknown because of 2).
4. The content of the "Your Certificates" tab is completely empty (empty state is missing*).
5. The content of the "People" tab is completely empty (empty state is missing*).
6. The order of the tabs is different than on the preferences screen (should be unified).

*) On the preferences screen there is alo no "empty state" text but there is an empty table and it's clear that there are no entries. But a completely empty content area looks like an error because it's not clear if content is missing or not.

Comment 1

[Johann Hofmann [:johannh]]

Thanks for reporting! We should probably fix some of these before going to release with the new standalone page :)

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1629590 - Correctly determine certificate types for the about:certificate standalone page.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1629590 - Don't show certificate categories on about:certificate if they're empty.

Depends on D72193

Comment 4

[Johann Hofmann [:johannh]]

These two patches should fix all of your issues, though I'm not 100% sure about the perf thing (#1). There was an error in the way we got the list of certificates which made us end up sending and rendering at least twice as many certs as we should have, so that likely had a perf impact, but it would be good if you could verify the improvement once this is in Nightly. If things are still slow please file a bug with a Firefox Performance Profile attached if possible (https://profiler.firefox.com/). Thanks!

Comment 5

[Johann Hofmann [:johannh]]

Carolina, do you have time to review these two small-ish patches or should I find someone else? :)

Thanks!

Comment 6

[Carolina Jimenez Gomez]

Hey Johann! Yes!, I'll take a look soon :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea828bc0282f
Correctly determine certificate types for the about:certificate standalone page. r=carolina.jimenez.g
https://hg.mozilla.org/integration/autoland/rev/7e982ad6250b
Don't show certificate categories on about:certificate if they're empty. r=carolina.jimenez.g

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ea828bc0282f
https://hg.mozilla.org/mozilla-central/rev/7e982ad6250b

Comment 9

[Sören Hentzschel]

Thanks for fixing the issues!

I'm not 100% sure about the perf thing (#1). There was an error in the way we got the list of certificates which made us end up sending and rendering at least twice as many certs as we should have, so that likely had a perf impact, but it would be good if you could verify the improvement once this is in Nightly.

Maybe there is a minor improvement, but it still takes several seconds on a Late 2018 MacBook Pro (2,6 GHz 6-Core Intel Core i7, 16 GB 2400 MHz DDR4).

Comment 10

[Johann Hofmann [:johannh]]

(In reply to Sören Hentzschel from comment #9)

Thanks for fixing the issues!

I'm not 100% sure about the perf thing (#1). There was an error in the way we got the list of certificates which made us end up sending and rendering at least twice as many certs as we should have, so that likely had a perf impact, but it would be good if you could verify the improvement once this is in Nightly.

Maybe there is a minor improvement, but it still takes several seconds on a Late 2018 MacBook Pro (2,6 GHz 6-Core Intel Core i7, 16 GB 2400 MHz DDR4).

Huh, I have a similar MacBook but I can not reproduce that at all. Do you have a lot of custom certificates imported? Again, it would be really nice to see a profile of this (and it shouldn't be hard to record).