1629664 - [dfpi] "Forget About This Site" should clear third party storage isolated under the first-party being cleared

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement, P2)

Description

[Steven Englehardt [:englehardt]]

With dfpi enabled (network.cookie.cookieBehavior=5) go to https://senglehardt.com/test/dfpi/first_and_third.html. Then, go into the History manager and click "Forget about this site" for senglehardt.com. This will clear the storage for senglehardt.com and test.senglehardt.com (with the exception of Bug 1629658), however the englehardt-tracker.com iframe isolated under does not have any of its isolated storage cleared.

We should clear these as well.

Comment 1

[Steven Englehardt [:englehardt]]

Another question to consider here: should using "Forget About This Site" on a site that is often visited as a first party (e.g., facebook.com) and also isolated under a large number of other first parties only delete the non-isolated storage (i.e., that without the double key) or should it delete both the non-isolated and isolated storage for that origin. The latter makes sense to me.

I think "forget about this site" should clear:

1. non-isolated storage for that site (e.g., facebook.com with no first-party key)
2. isolated storage for that site (e.g., facebook.com storage that has a first-party key)
3. storage isolated under that site (e.g., foo.com which has the first-party key facebook.com)

Comment 2

[Johann Hofmann [:johannh]]

I agree that it should clear all of that :)

Comment 4

[Paul Zühlcke [:pbz]]

I've had a look at this. The context menu calls ForgetAboutSite#removeDataFromDomain with the CLEAR_FORGET_ABOUT_SITE flag. We can extend ClearDataService#deleteDataFromHost to also clear (2) and (3) if that flag is passed.
For (3) we can use Cleaner#deleteByOriginAttributes. However, we don't seem to have a way to construct the partition key from JS yet.

Comment 5

[Paul Zühlcke [:pbz]]

I have some WIP patches for this, but I'm unassigning for now until we have a timeline for this project.