Closed Bug 1629757 Opened 4 months ago Closed 4 months ago

Unloaded about:addons tab should be reused after session restore

Categories

(Toolkit :: Add-ons Manager, defect, P3)

77 Branch
defect
Points:
1

Tracking

()

VERIFIED FIXED
mozilla77
Iteration:
77.2 - Apr 20 - May 3
Tracking Status
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- verified

People

(Reporter: tustamido, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Once about:addons is open, its tab is always focused (reused) when you click to open Add-ons or press Ctrl+Shift+A. But after a session restore with about:addons as an unloaded tab, BrowserOpenAddonsMgr() will open a new tab instead of just switch and load the unloaded about:addons tab.

I suspect that the current behavior is not intended, as this doesn't happen with about:preferences -> openPreferences().

By the way, I think Firefox should standardize reuse of all about: tabs like about:logins and about:support.

Component: Tabbed Browser → Add-ons Manager
Product: Firefox → Toolkit

Tested on Windows PRo 10 64-bit and macOS 10.15 Catalina on FF 77.0a1 (20200416094846), 76.0b5 (20200415234430) and 75.0 (20200403170909) managed to repro using the following steps:

  1. launch Browser and open about:addons.
  2. Open about:preferences and select "restore previous session"
  3. Open another tab and type in a random address( wikipedia.com) and restart browser.
  4. From Hamburger menu go to Options(Preferences) and notice that a switch is performed to previously open tab and tab is loaded.
  5. Also from Hamburger menu> Add-ons or using Ctrl+Shift+A navigate to about:addons.

Expected result:
As for about:preferences, switch is performed to about:addons tab which was opened in the previous session.

Actual results:
A new about:addons page is opened.

Note: This does not appear to be a regression but rather a behavior that could stand to be improved.

Status: UNCONFIRMED → NEW
Ever confirmed: true

about:addons currently uses some "EM-{ping,pong,loaded}" observer messages to communicate if it is open or not. Ideally it could use switchToTabHavingURI() which should avoid this issue, but we'll need to make sure there are no regressions with how views are loaded from outside of about:addons (shortcut, Manage Extensions/Report Extension on browser/page action, etc).

Priority: -- → P3
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 77.2 - Apr 20 - May 3
Points: --- → 1
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e7e1b495d96e
Use switchToTabHavingURI to load about:addons. r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
Flags: qe-verify+

Confirmed issue with 77.0a1 (2020-04-13) for Windows 10.
Fix verified with 77.0b2, Windows 10, Ubuntu 20, macOS 10.15.3.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.