1629770 - Make XUL popup on HTML document that has Chrome privilege available

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Daisuke Akatsuka (:daisuke)]

For now, we can not use XUL wrapper popup on HTML document of even DevTools.
That causes the issue such as bug 1620098.
In this bug, as Brendan said in https://phabricator.services.mozilla.com/D67983#2103563, we change the condition to make XUL popup on HTML document that has Chrome privilege available.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Hi Brendan! I'm sorry to bother you.
I want to fix bug 1620098 by this release cycle, can you have time to fix this one?

Comment 2

[Brendan Dahl [:bdahl]]

If my try run goes smoothly I'll put this up for review.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Hi, thank you very much!
I tried to fix bug 1620098 with your patch, it seems working fine!

Comment 4

[Brendan Dahl [:bdahl]]

Attachment: Bug 1629770 - Create popupgroup for any main process system privileged documents. r=emilio

Fixes tooltips/menus in responsive design mode. A few accesibility tests
had to be adjusted since popupgroups are now automatically created
for them.

Comment 5

[Brendan Dahl [:bdahl]]

Attachment: Bug 1629770 - Create popupgroup for any main process system privileged documents. r=emilio

Fixes tooltips/menus in responsive design mode. The "presentation" role
was added to the tooltip element to keep system privilege a11y tests
working.

Comment 6

[Brendan Dahl [:bdahl]]

Attachment: Bug 1629770 - Create popupgroup for any main process system privileged documents. r=emilio

Fixes tooltips/menus in responsive design mode. The "presentation" role
was added to the tooltip element to keep system privilege a11y tests
working.

https://phabricator.services.mozilla.com/D72400

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b76e3b62c099
Create popupgroup for any main process system privileged documents. r=emilio,Jamie

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b76e3b62c099

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Brendan, thanks for fixing this bug, I appreciate that!
It was of of the blocker for the RDM Fission work.

Comment 10

[Daisuke Akatsuka (:daisuke)]

Thank you very very much for fixing this, Brendan!