Closed Bug 1652211 Opened 3 months ago Closed 2 months ago

Added anonymous tooltip to mochitest docs messes with text

Categories

(Core :: Disability Access APIs, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

The following markup should produce a doc accessible with a text value of "hello world", and a single text leaf with the same name.

<html><head></head><body>hello world</body></html>

In a mochitest environment a hidden tooltip is appended to the doc accessible's children (because the html is now chrome privileged). This has the result of adding a trailing whitespace to the doc's text value, and this messes getting text at offset with word end bounds on the last word.

Tooltips are tricky because they don't participate in the text flow, even when they are showing. Additionally, current behavior of having invisible tooltips hang around and still emit show/hide is counter productive in several other cases as well like extra cursor stops in VoiceOver.

I propose that xul tooltip accessibles should be created and destroyed with each show/hide event like almost any other kind of accessible.

Assignee: nobody → eitan
Status: NEW → ASSIGNED
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99402617d852
Create and destroy xul tooltips as they appear and go away. r=Jamie

Backed out for failures on test_tooltip.xhtml

backout: https://hg.mozilla.org/integration/autoland/rev/52ea6cafcf4054b8b651efcf8c8b86d862d63478

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=99402617d852d9e270eec7c7ac6eff2f457e54ed&searchStr=mochitest-a11y-1proc%2Ca11y&selectedTaskRun=dvsUjB4pTQ-A3u0Hn1kBGg.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309810986&repo=autoland&lineNumber=5274

[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - TEST-PASS | accessible/tests/mochitest/treeupdate/test_tooltip.xhtml | Wrong last child of ['vbox@id="tooltip-container" node', address: [object XULElement], role: grouping, address: 0x7fc441fb1d40]
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - Buffered messages finished
[task 2020-07-15T04:00:41.129Z] 04:00:41 ERROR - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/treeupdate/test_tooltip.xhtml | application terminated with exit code 11
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - runtests.py | Application ran for: 0:06:10.136450
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - zombiecheck | Reading PID log: /tmp/tmpLt9CNGpidlog
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - ==> process 1259 launched child process 1277
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - ==> process 1259 launched child process 1635
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - ==> process 1259 launched child process 1783
[task 2020-07-15T04:00:41.129Z] 04:00:41 INFO - zombiecheck | Checking for orphan process with PID: 1635
[task 2020-07-15T04:00:41.130Z] 04:00:41 INFO - zombiecheck | Checking for orphan process with PID: 1277
[task 2020-07-15T04:00:41.130Z] 04:00:41 INFO - zombiecheck | Checking for orphan process with PID: 1783
[task 2020-07-15T04:00:41.130Z] 04:00:41 INFO - mozcrash Copy/paste: /builds/worker/fetches/minidump_stackwalk/minidump_stackwalk /tmp/tmp8mFQ0x.mozrunner/minidumps/460618b5-b8bf-77fc-45dc-204564f4c552.dmp /builds/worker/workspace/build/symbols
[task 2020-07-15T04:00:47.840Z] 04:00:47 INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/460618b5-b8bf-77fc-45dc-204564f4c552.dmp
[task 2020-07-15T04:00:47.840Z] 04:00:47 INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/460618b5-b8bf-77fc-45dc-204564f4c552.extra
[task 2020-07-15T04:00:48.007Z] 04:00:48 INFO - PROCESS-CRASH | accessible/tests/mochitest/treeupdate/test_tooltip.xhtml | application crashed [@ nsINode::AsContent()]

Flags: needinfo?(eitan)
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/964ee25fb67c
Create and destroy xul tooltips as they appear and go away. r=Jamie
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(eitan)
You need to log in before you can comment on or make changes to this bug.