1629920 - [False Negative] Password generation is not offered for the password field on facebook.com change form

Status: NEW

(Toolkit :: Password Manager: Site Compatibility, defect, P2)

Description

[Timea Cernea [:tbabos][inactive]]

Affected Versions:
Nightly 77.0a1 (2020-04-14) (64-bit)
Beta 76.0b4

Affected Platforms:
Windows 7/10 x64
MacOS 10.14
Ubuntu 18.04

Steps to reproduce:

1. Go to facebook.com and reach the Change Password
   credentials to test this:
   [e-mail] pass: NicoKlaus#123
2. Click on the New Password and Retype Password fields

Expected Result:
The autocomplete dropdown should display the Password Generation option for both password fields

Actual Result:
Password Generation was not offered for password fields

Regression-Range:
Not a regression of this implementation, it can also be reproduced in Release 75

Notes:
<input class="_58al _2gnb" type="password" aria-errormessage="js_ha" aria-invalid="true" aria-labelledby="js_h8" autocomplete="disable_autocomplete" id="js_h7" value="">

This does not happen for all Facebook accounts (different Facebook interface?) but it is 100% repro with the credentials given in steps

Comment 1

[Bianca Danforth [:bdanforth]]

According to its Tranco + Alexa ranking, this site is among the most popular (which we are currently defining to be the top 500).

Comment 2

[Matthew N. [:MattN]]

Erik is working on a model update to potentially address this.

Comment 3

[Erik Rose [:erik][:erikrose]]

The model update landed at https://github.com/mozilla-services/fathom-login-forms/commit/368cbce234fcd2804f82d88d10ac940b8243c496 fixes this.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Assigning severity. Priority-wise we should still get to this sooner rather than later.

Comment 5

[:severin Rudie]

When testing the model update in bug 1638187 I found that the "new password" field was not being recognized (score: 0.3350142757914845) while "re-type password" was (score: 0.7748064545910444).

It's worth noting that this is a live page, though, and these results have been somewhat flaky.

Comment 6

[Matthew N. [:MattN]]

Bumping down to P2 since although this is a popular website, the issue is a false negative, not a false positive and the user can use the context menu as a fallback.