1631818 - [False Negative] Password generation is not offered for the New password field on facebook.com recovery form

Status: NEW

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Rares Doghi, Desktop QA]

Affected Versions:
Nightly 77.0a1 (2020-04-20) (64-bit)
Beta 76.0b6
Release 75.0

Affected Platforms:
Windows 7/10 x64
MacOS 10.14
Ubuntu 18.04

Steps to reproduce:

Go to facebook.com and reach the Forgot Password option.
Ask to reset your password via email.
Enter the Code received in the email and reach the New Password page.
Click in the New Password field.

Expected Result:
The autocomplete dropdown should display the Password Generation option for the New Password field.

Actual Result:
Password Generation was not offered for the New password field.

Regression-Range:
Not a regression of this implementation, it can also be reproduced in Release 75

Notes:
<input type="text" class="inputtext 55r1 41sy" id="password_new" name="password_new" tabindex="1" autocomplete="off" aria-describedby="password_new_status">

Comment 1

[Bianca Danforth [:bdanforth]]

According to its Tranco + Alexa ranking, this site is among the most popular (which we are currently defining to be the top 500).

Comment 2

[Erik Rose [:erik][:erikrose]]

The model update landed at https://github.com/mozilla-services/fathom-login-forms/commit/368cbce234fcd2804f82d88d10ac940b8243c496 fixes this.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Assigning severity. Priority-wise we should still get to this sooner rather than later.

Comment 4

[:severin Rudie]

When testing the model update in bug 1638187 I found that LoginAutoComplete#startSearch was not being hit on this page, meaning our Fathom ruleset was never being executed.

It's worth noting that this is a live page, though, and these results have been somewhat flaky.

Comment 5

[Matthew N. [:MattN]]

Bumping down to P2 since although this is a popular website, the issue is a false negative, not a false positive and the user can use the context menu as a fallback.

Comment 6

[Sergey Galich [:serg]]

Moving to P3 as this is not happening in the next release cycle.