1630066 - test_ext_sendmessage_reply2.html is busted on Android (DocumentChannel)

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, defect, P2)

Description

[Dylan Roeh (:droeh) (he/him)]

This was temporarily disabled to land bug 1619798 -- setting browser.tabs.documentchannel to true causes this test to fail.

Comment 1

[Dylan Roeh (:droeh) (he/him)]

Attachment: Bug 1630066 - Reenable test_ext_sendmessage_reply2.html on GeckoView. r=#geckoview-reviewers!

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Put up a patch to reenable this test since extension process is not going to be enabled on GV for a while; renaming to indicate the actual issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d91e35044576
Reenable test_ext_sendmessage_reply2.html on GeckoView. r=agi

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_ext_sendmessage_reply2.html

backout: https://hg.mozilla.org/integration/autoland/rev/999a0b61d38d29eea6d5b18bb0037ae9ee2cd7b4

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d91e35044576e411cf8c8b3d0da524673bd89291&searchStr=android%2C7.0%2Cx86-64%2Copt%2C&selectedTaskRun=aP3drKoMShmR11d2G3SByQ-0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300280512&repo=autoland&lineNumber=8862

[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - 6217 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html | [e-mail]: Correct content script response token - Expected: 0.08757635482381254-done, Actual: 0.08757635482381254-done
[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - 6218 INFO TEST-PASS | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html | [e-mail]: Got content script message
[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - 6219 INFO add_task | Leaving test test_contentscript
[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - Buffered messages finished
[task 2020-04-30T20:24:06.755Z] 20:24:06 WARNING - 6220 INFO TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html | message queue is empty - got "["content-script-done"]", expected "[]"
[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:383:14
[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - ExtensionTestUtils.loadExtension/<@SimpleTest/ExtensionTestUtils.js:32:18
[task 2020-04-30T20:24:06.755Z] 20:24:06 INFO - executeCleanupFunction@SimpleTest/SimpleTest.js:1480:13
[task 2020-04-30T20:24:06.756Z] 20:24:06 INFO - 6221 INFO TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html | took 422ms
[task 2020-04-30T20:24:06.756Z] 20:24:06 INFO - 6222 ERROR /tests/toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html logged result after SimpleTest.finish(): message queue is empty

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Looks like this is due to Bug 1644039.

Comment 6

[Chris Peterson [:cpeterson]]

Tracking this bug for Android Fission milestone M2 (pass tests with Fission enabled).

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:fluffyemily, maybe it's time to close this bug?

Comment 8

[Chris Peterson [:cpeterson]]

This test is still disabled on Android:

[test_ext_sendmessage_reply2.html]
skip-if = os == 'android'

https://searchfox.org/mozilla-central/rev/1fb9316c260bddcd5e6aa2ca1b04e46cb5afb7fd/toolkit/components/extensions/test/mochitest/mochitest-common.ini#166-167

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Redirect needinfos that are pending on inactive users to the triage owner.
:amoya, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Chris Peterson [:cpeterson]]

kmag, this test_ext_sendmessage_reply2.html test is disabled on Android. Someone tried to re-enable the test two years ago, but it was backed out (comment #4).

Agi said in comment #5 this bug might be related to bug 1644039, intermittent test failures caused by window.close().

Comment 11

[Chris Peterson [:cpeterson]]

Moving Android Fission bugs to the new GeckoView::Sandboxing component.

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

I wasn't hitting a failure by running this test locally on GeckoView, let's see if a failure is hit in a push to try:

• https://treeherder.mozilla.org/jobs?repo=try&revision=10a3d1dc3d35b28e172c4a720b85a8183a643c72

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

The test file test_ext_sendmessage_reply2.html didn't trigger a failure in the try push from comment 12, and I confirmed that the test did run and pass in that try push (logs extracted from the live_backing.log file linked to the job test-android-em-7.0-x86_64-qr/opt-geckoview-mochitest-plain-nofis-1):

...
[task 2023-07-28T13:01:51.837Z] 13:01:51     INFO -  Running manifest: toolkit/components/extensions/test/mochitest/mochitest-remote.ini:toolkit/components/extensions/test/mochitest/mochitest-common.ini
...
[task 2023-07-28T13:04:28.092Z] 13:04:28     INFO -  TEST-START | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html
[task 2023-07-28T13:04:28.092Z] 13:04:28     INFO -  TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html | took 1896ms
...
[task 2023-07-28T13:06:43.111Z] 13:06:43     INFO -  Running manifest: toolkit/components/extensions/test/mochitest/mochitest.ini:toolkit/components/extensions/test/mochitest/mochitest-common.ini
...
[task 2023-07-28T13:09:29.470Z] 13:09:29     INFO -  TEST-START | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html
[task 2023-07-28T13:09:29.470Z] 13:09:29     INFO -  TEST-OK | toolkit/components/extensions/test/mochitest/test_ext_sendmessage_reply2.html | took 1894ms
...

The first run is originated from mochitest-remote.ini and so it is running the test with the extensions in the child extension process, the second one is originated from mochitest.ini and so it is running the test with the extensions in the parent process.

I'm going to attach the patch to this bug and run one last try push with a temporary change applied to the test file, to force it to be executed in verify mode by the TV job.

Comment 14

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1630066 - Re-enable test_ext_sendmessage_reply2.html on Android. r?willdurand!

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

New push to try with the patch attached in comment 14 + a temporary one to force test_ext_sendmessage_reply2.html to be executed as part of the TV job:

• https://treeherder.mozilla.org/jobs?repo=try&revision=eca4be66b24b4cd2fd38f6fa687f3e48d23d1c8f

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54feb0d337d8
Re-enable test_ext_sendmessage_reply2.html on Android. r=willdurand

Comment 17

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/54feb0d337d8