Closed Bug 1630152 Opened 5 years ago Closed 5 years ago

Perma browser_html_detail_view.js/browser_html_discover_view.js/... | parent must be in snapshot. Has []. - false == true - JS frame :: TelemetryTestUtils.jsm :: assertEvents :: line 138 when version number gets increased to 78 on 2020-05-06

Categories

(Toolkit :: Add-ons Manager, defect, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 + verified

People

(Reporter: malexandru, Assigned: rpl)

References

Details

Central as version increase simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=297508230&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=4b5ccefba5f619f1940a9bb21aae5e5b7072fb9c&searchStr=%28bc

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=297508230&repo=try&lineNumber=10050

[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_permissions_local_file.js | ["installLocalRejected","installLocalRejected","installLocalAccepted"] deepEqual ["installLocalRejected","installLocalRejected","installLocalAccepted"] - 
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_permissions_local_file.js | There was an installId found - 
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - Buffered messages finished
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/webextensions/browser_permissions_local_file.js | Got parent telemetry events in the snapshot - 
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - Stack trace:
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - chrome://mochikit/content/browser-test.js:test_ok:1274
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_permissions_local_file.js:test_install_extension_from_local_file:56
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1044
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1079
[task 2020-04-14T11:57:22.006Z] 11:57:22     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:909
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/webextensions/browser_permissions_local_file.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_permissions_local_file.js:62 - TypeError: can't access property "filter", snapshot.parent is undefined
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - Stack trace:
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - test_install_extension_from_local_file@chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_permissions_local_file.js:62:23
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1044:34
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1079:11
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:909:14
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - Leaving test bound test_install_extension_from_local_file
[task 2020-04-14T11:57:22.007Z] 11:57:22     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_permissions_local_file.js | No unexamined telemetry after test is finished - 
[task 2020-04-14T11:57:22.008Z] 11:57:22     INFO - TEST-FAIL | browser/base/content/test/webextensions/browser_permissions_local_file.js | Assertion count 6 is greater than expected range 0-0 assertions. - 
[task 2020-04-14T11:57:22.008Z] 11:57:22     INFO - GECKO(1192) | MEMORY STAT | vsize 938MB | vsizeMaxContiguous 577MB | residentFast 363MB | heapAllocated 146MB
[task 2020-04-14T11:57:22.008Z] 11:57:22     INFO - TEST-OK | browser/base/content/test/webextensions/browser_permissions_local_file.js | took 5258ms
<...>
[task 2020-04-14T12:20:03.330Z] 12:20:03     INFO - Console message: 1586866803247	addons.xpi	DEBUG	Calling bootstrap method shutdown on test2@mochi.test version 1.0
[task 2020-04-14T12:20:03.331Z] 12:20:03     INFO - Console message: 1586866803276	addons.xpi	DEBUG	Calling bootstrap method uninstall on test2@mochi.test version 1.0
[task 2020-04-14T12:20:03.331Z] 12:20:03     INFO - Console message: 1586866803280	addons.xpi	DEBUG	Disabling XPIState for test2@mochi.test
[task 2020-04-14T12:20:03.331Z] 12:20:03     INFO - Buffered messages finished
[task 2020-04-14T12:20:03.331Z] 12:20:03     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | parent must be in snapshot. Has []. - false == true - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 138
[task 2020-04-14T12:20:03.331Z] 12:20:03     INFO - Stack trace:
[task 2020-04-14T12:20:03.331Z] 12:20:03     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:138
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:assertAboutAddonsTelemetryEvents:1623
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js:testOpenDetailView:242
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1044
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1079
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:909
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-04-14T12:20:03.332Z] 12:20:03     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | Uncaught exception - at resource://testing-common/TelemetryTestUtils.jsm:162 - TypeError: can't access property "map", snapshot is undefined
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - Stack trace:
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - assertEvents@resource://testing-common/TelemetryTestUtils.jsm:162:20
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - assertAboutAddonsTelemetryEvents@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1623:22
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - testOpenDetailView@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js:242:35
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1044:34
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1079:11
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:909:14
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - Leaving test bound testOpenDetailView
[task 2020-04-14T12:20:03.333Z] 12:20:03     INFO - Entering test bound testDetailOperations
<...>
[task 2020-04-14T12:20:04.760Z] 12:20:04     INFO - Manager window close() call returned
[task 2020-04-14T12:20:04.781Z] 12:20:04     INFO - GECKO(1620) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 81: TypeError: can't access property "ownerGlobal", browser is null
[task 2020-04-14T12:20:04.816Z] 12:20:04     INFO - Console message: [JavaScript Error: "TypeError: can't access property "ownerGlobal", browser is null" {file: "resource://gre/actors/BrowserElementParent.jsm" line: 81}]
[task 2020-04-14T12:20:04.871Z] 12:20:04     INFO - Console message: 1586866804790	addons.xpi	DEBUG	Calling bootstrap method shutdown on test@mochi.test version 1.0
[task 2020-04-14T12:20:04.906Z] 12:20:04     INFO - Console message: 1586866804871	addons.xpi	DEBUG	Calling bootstrap method uninstall on test@mochi.test version 1.0
[task 2020-04-14T12:20:04.907Z] 12:20:04     INFO - Console message: 1586866804874	addons.xpi	DEBUG	Disabling XPIState for test@mochi.test
[task 2020-04-14T12:20:04.907Z] 12:20:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | parent must be in snapshot. Has []. - false == true - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 138
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - Stack trace:
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:138
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:assertAboutAddonsTelemetryEvents:1623
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js:testDetailOperations:374
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1044
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1079
[task 2020-04-14T12:20:04.908Z] 12:20:04     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:909
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js | Uncaught exception - at resource://testing-common/TelemetryTestUtils.jsm:162 - TypeError: can't access property "map", snapshot is undefined
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - Stack trace:
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - assertEvents@resource://testing-common/TelemetryTestUtils.jsm:162:20
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - assertAboutAddonsTelemetryEvents@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1623:22
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - testDetailOperations@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js:374:35
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1044:34
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1079:11
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:909:14
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - Leaving test bound testDetailOperations
[task 2020-04-14T12:20:04.909Z] 12:20:04     INFO - Entering test bound testFullDetails
<...>
[task 2020-04-14T12:20:42.002Z] 12:20:42     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | addon-installed notification shown - 
[task 2020-04-14T12:20:42.003Z] 12:20:42     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | notification panel open - 
[task 2020-04-14T12:20:42.003Z] 12:20:42     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | checkbox visibility is correct - 
[task 2020-04-14T12:20:42.004Z] 12:20:42     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | The installed add-on should have the expected telemetry info - {"source":"disco"} deepEqual {"source":"disco"} - 
[task 2020-04-14T12:20:42.004Z] 12:20:42     INFO - TEST-PASS | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | The Install buttons should be replaced with Manage buttons - ["manage-addon","manage-addon","install-addon","install-addon","install-addon","install-addon","install-addon","install-addon","install-addon","open-amo"] deepEqual ["manage-addon","manage-addon","install-addon","install-addon","install-addon","install-addon","install-addon","install-addon","install-addon","open-amo"] - 
[task 2020-04-14T12:20:42.004Z] 12:20:42     INFO - Buffered messages finished
[task 2020-04-14T12:20:42.004Z] 12:20:42     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | parent must be in snapshot. Has []. - false == true - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 138
[task 2020-04-14T12:20:42.004Z] 12:20:42     INFO - Stack trace:
[task 2020-04-14T12:20:42.005Z] 12:20:42     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:138
[task 2020-04-14T12:20:42.005Z] 12:20:42     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:assertAboutAddonsTelemetryEvents:1623
[task 2020-04-14T12:20:42.005Z] 12:20:42     INFO - chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js:install_from_discopane:480
[task 2020-04-14T12:20:42.005Z] 12:20:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1044
[task 2020-04-14T12:20:42.005Z] 12:20:42     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1079
[task 2020-04-14T12:20:42.006Z] 12:20:42     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:909
[task 2020-04-14T12:20:42.006Z] 12:20:42     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-14T12:20:42.006Z] 12:20:42     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-04-14T12:20:42.006Z] 12:20:42     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js | Uncaught exception - at resource://testing-common/TelemetryTestUtils.jsm:162 - TypeError: can't access property "map", snapshot is undefined
[task 2020-04-14T12:20:42.006Z] 12:20:42     INFO - Stack trace:
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - assertEvents@resource://testing-common/TelemetryTestUtils.jsm:162:20
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - assertAboutAddonsTelemetryEvents@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/head.js:1623:22
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - install_from_discopane@chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_discover_view.js:480:35
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1044:34
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1079:11
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:909:14
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - Leaving test bound install_from_discopane
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - Entering test bound discopane_navigate_while_loading
[task 2020-04-14T12:20:42.007Z] 12:20:42     INFO - Loading manager window in tab

Here we have multiple failures all complaining about TelemetryTestUtils.jsm

Mike, could you please take a look, or redirect this to someone who could?
Thank you!

Flags: needinfo?(mconley)

This is due to addonManager events expiring in 78.
Last person to bump them was rpl.

Moving to their component and ni?

Component: Telemetry → Add-ons Manager
Flags: needinfo?(mconley) → needinfo?(lgreco)
Depends on: 1630596
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Flags: needinfo?(lgreco)
Priority: -- → P1

Hi Alexandru,
Bug 1630596 has been landed and so this should now be fixed, do you confirm that this perma fail does not happen anymore in a new 78 version increase simulation?

Flags: needinfo?(malexandru)

Code sheriffs will run the next version increase simulation on Monday and resolve this bug if the issue is gone.

Flags: needinfo?(malexandru)
Status: RESOLVED → VERIFIED
status-firefox77: affected → verified
You need to log in before you can comment on or make changes to this bug.