1629910 - browser_PageActions_removeExtension.js/ browser_lwt_telemetry.js/ browser_PageActions.js is going to permafail when Gecko version number increases to 78 on on 2020-05-04

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Cosmin Sabou [:CosminS]]

[Tracking Requested - why for this release]:

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=4b5ccefba5f619f1940a9bb21aae5e5b7072fb9c&searchStr=%28bc&selectedJob=297508486

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=297508486&repo=try

[task 2020-04-14T11:43:16.714Z] 11:43:16     INFO - TEST-PASS | browser/base/content/test/pageActions/browser_PageActions_removeExtension.js | 'Remove' item is not disabled - true == true - 
[task 2020-04-14T11:43:16.714Z] 11:43:16     INFO - Buffered messages finished
[task 2020-04-14T11:43:16.714Z] 11:43:16     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/pageActions/browser_PageActions_removeExtension.js | parent must be in snapshot. Has []. - false == true - JS frame :: resource://testing-common/TelemetryTestUtils.jsm :: assertEvents :: line 138
[task 2020-04-14T11:43:16.714Z] 11:43:16     INFO - Stack trace:
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - resource://testing-common/TelemetryTestUtils.jsm:assertEvents:138
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - chrome://mochitests/content/browser/browser/base/content/test/pageActions/browser_PageActions_removeExtension.js:contextMenu_removeExtension_panel:80
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1044
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1079
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:909
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-14T11:43:16.715Z] 11:43:16     INFO - Not taking screenshot here: see the one that was previously logged

Comment 1

[Cosmin Sabou [:CosminS]]

Was last touched by https://hg.mozilla.org/mozilla-central/rev/ce1ade5464ee in Bug 1590736. Luca, could you please have a look over this? Thank you.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Cosmin Sabou [:CosminS] from comment #1)

Was last touched by https://hg.mozilla.org/mozilla-central/rev/ce1ade5464ee in Bug 1590736. Luca, could you please have a look over this? Thank you.

Sure, I'm assigning it to myself (to see if any of them are not actually used and remove them, and extend the probes that have to keep).

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

The following probes are the ones that in my opinion we will want to extend:

• I'm pretty sure that addonsManager.install/addonsManager.manage are being used in the addons daily derived dataset, and we have also used them to determine the most used install locations

• addonsManager.report has been used to investigate issues related to the integrated abuse reporting

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

The following probes are the one that I'm not sure if they are being used in any dashboard / reports or if they turned out to be helpful to investigate about:addons issues (and so we should double-check if we can remove them):

• addonsManager.link
• addonsManager.view
• addonsManager.action

Mark, these are all probes that we initially added as part of Bug 1500147, do you know who we should ask to know if they are being used in any dashboard or reports? (or if you did used any of them to investigate something related to about:addons)

Comment 5

[Mark Striemer [:mstriemer]]

I think Jorge should decide if we want to keep this data around to make decisions in the future.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

We've used them a couple of times in the past (1, 2), and I expect we'll continue needing them in the future. Our ownership of this code is fairly recent, so we haven't done much in this area yet, but it should hopefully change.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Cosmin,
Bug 1630596 has been landed and so this should now be fixed, do you confirm that this perma fail does not happen anymore in a new 78 version increase simulation?

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Code sheriffs will run the next version increase simulation on Monday and resolve this bug if the issue is gone.

Comment 9

[Alexandru Michis [:malexandru]]

Verified fixed in today's central as version increase simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=56005e89ee3a807791a0457f6fab7c4d47150779&searchStr=%28bc