1630279 - Disable the disabling of DComp so we get more testing.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This is in anticipation of having a looser condition for enabling
DComp. Until that code is ready we might as well get more testing.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1630279 - Disable the disabling of DComp so we get more testing.

This is in anticipation of having a looser condition for enabling
DComp. Until that code is ready we might as well get more testing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585805287f9d
Disable the disabling of DComp so we get more testing. r=aosmond

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9140780 [details]
Bug 1630279 - Disable the disabling of DComp so we get more testing.

Beta/Release Uplift Approval Request

• User impact if declined: Some users in 76 won't get DirectComposition
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just enables a code path that is already shipping in more configurations. It's easy disable if there's any indication that it's bad.
• String changes made/needed:

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/585805287f9d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

IIUC, DComp was disabled due to bug 1618370. What's changed about our understanding of the bug which has caused us to change our mind about disabling the feature for it?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

The plan is to land bug 1630371 before this goes to release which should avoid bug 1618370. This is just landing early so we get extra testing.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9140780 [details]
Bug 1630279 - Disable the disabling of DComp so we get more testing.

Dropping beta request as we missed the build and we can just set the condition we want directly in bug 1630371