1630282 - Not all locales have the same number of map service prefs

Status: RESOLVED FIXED

(MailNews Core :: Localization, task)

Description

[Ian Neal]

At the moment l10n.toml ignores parts of region.properties for when a locale has a different number of prefs to en-US, e.g. for search prefs, but there isn't anything to cover mapit_url

Comment 1

[Ian Neal]

Attachment: Add ignore for mapit

This seems to be the right syntax and seems to work but asking Pike for feedback to confirm

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 9140781 [details] [diff] [review]
Add ignore for mapit

Review of attachment 9140781 [details] [diff] [review]:
-----------------------------------------------------------------

This also needs a change to the respective `filter.py` files, but as far as the toml files are concerned, this is OK.

Now, conceptually, it'd be good to get rid of these entries altogether. It's really not something that localizers can properly handle, and for the m-c products, we moved most of that stuff into the core code.

Comment 3

[Ian Neal]

Attachment: Add ignore for mapit v1.1

Update patch from feedback and created some bugs to cover part of the work for the centralisation of these settings.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 9140856 [details] [diff] [review]
Add ignore for mapit v1.1

Review of attachment 9140856 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0665e9d6b9ec
Not all locales have the same number of map service prefs. r=rjl