1630286 - Subscribe window "Show items that contain" should not be shown at all for IMAP

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[bugzilla]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

I have the Czech version 68.7.0. (64-bit). I have a lot of folders and a deep hierarchy. In "Subscribe ..." (in Czech "Správce odebírání ...") menu, I need to look for some folder name to be able to stop subscribing in the item "Show items that contain" (in Czech "Zobrazit položky které obsahují:"). This item is gray and I can not use it.

Actual results:

nothing

Expected results:

I would like to obtain a list of selected folders

Comment 1

[Magnus Melin [:mkmelin]]

We shouldn't show that field at all for IMAP, as it's just confusing. It only applies to (in reality) NNTP - https://searchfox.org/comm-central/rev/e1f037dd2e1292f1fbff005a4729b95412c2e625/mailnews/base/content/subscribe.js#148

Comment 2

[Firefox Bug Husbandry Bot]

Resetting severity to default of --.

Comment 3

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (Backlog,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 4

[Favour]

Hi, I am an Outreachy applicant interested in fixing this bug. I wish to take up this issue... could you pls guide me?

Comment 5

[Magnus Melin [:mkmelin]]

Please see the code linked in comment 1. You want set element.hidden = true on appropriate element(s) if the server.type != "nntp".

Comment 6

[Favour]

please boss i setup firefox code env and i cloned the code base inside mozilla-source with unified but I cant find this comm-central folder

Comment 7

[Favour]

please if there is anything am missing out I will appreciate if you brief me on it. Thanks boss

Comment 8

[Magnus Melin [:mkmelin]]

See instructions at https://developer.thunderbird.net/thunderbird-development/getting-started

Comment 9

[Toby Pilling [:tobyp]]

Attachment: Bug 1630286 - Hide Subscribe folder search options when not NNTP. r=freaktechnik

== How to Test ==

• Ensure that you have both NNTP and IMAP accounts set up
• Open Subscribe window
• Choose an IMAP account
• [folder search row should be hidden]
• Choose NNTP account
• [folder search row should be visible and operational]

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5540a47892ae
Hide Subscribe folder search options when not NNTP. r=freaktechnik