Closed Bug 1630369 Opened 2 years ago Closed 2 years ago

Building on windows broken when --enable-openpgp used

Categories

(MailNews Core :: Build Config, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: rjl, Assigned: rjl)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Building with --enable-openpgp is currently broken when building on Windows.

 0:44.31 Error opening file "None"
 0:44.37 Traceback (most recent call last):
 0:44.37   File "c:\moz\mozilla-central\python\mozbuild\mozbuild\action\file_generate.py", line 72, in main
 0:44.44     ret = module.__dict__[method](output, *args.additional_arguments, **kwargs)
 0:44.48   File "c:/moz/mozilla-central/comm/third_party/botan/botan_configure.py", line 61, in main
 0:44.50     rv = _run_configure(args)
 0:44.53   File "c:/moz/mozilla-central/comm/third_party/botan/botan_configure.py", line 52, in _run_configure
 0:44.58     rv = get_cmd_output(*args)
 0:44.61   File "c:/moz/mozilla-central/comm/third_party/botan/botan_configure.py", line 38, in get_cmd_output
 0:44.62     close_fds=os.name != 'nt')
 0:44.66   File "C:\mozilla-build\python3\Lib\subprocess.py", line 775, in __init__
 0:44.69     restore_signals, start_new_session)
 0:44.70   File "C:\mozilla-build\python3\Lib\subprocess.py", line 1178, in _execute_child
 0:44.73     startupinfo)
 0:44.78 OSError: [WinError 193] %1 is not a valid Win32 application
Blocks: 1628424
Windows cannot execute a Python script directly like UNIX can,
so call configure.py as "python configurey.py" instead.
Attachment #9140857 - Flags: review?(geoff)
Assignee: nobody → rob
Status: NEW → ASSIGNED
Comment on attachment 9140857 [details] [diff] [review]
Run Botan configure.py with Python executable

There's a typo in the commit message.
Attachment #9140857 - Flags: review?(geoff) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5153862b3aba
Run Botan configure.py with Python executable. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 77.0
Keywords: regression
You need to log in before you can comment on or make changes to this bug.