1628424 - Build/Include the OpenPGP code by default in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert [:KaiE:]]

The OpenPGP code should soon be ready for initial testing in nightly/daily Thunderbird builds. To enable it, we can flip the build pref.

Comment 1

[Kai Engert [:KaiE:]]

This needs to land at the same time as bug 1625135, to ensure existing tests will continue to pass.

To actually being able to use the code, we need the RNP library and dependencies, as tracked in bug 1621785.
However, it's not a strict dependency at this time, because with the changes from bug 1625574, we should be able to fail gracefull, and non-OpenPGP code still runs.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Bug 1628424 - Build/Include the OpenPGP code by default in comm-central. r=mkmelin

Comment 3

[Kai Engert [:KaiE:]]

We need the patch "Remove old migration code and setup wizard" from bug 1631019 before enabling by default.
Without it, we get a test failure, with the symptom described in bug 1631019 comment 3.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: disable-wizard-hotfix.patch

(In reply to Kai Engert (:KaiE:) from comment #3)

We need the patch "Remove old migration code and setup wizard" from bug 1631019 before enabling by default.
Without it, we get a test failure, with the symptom described in bug 1631019 comment 3.

That patch is a little bigger and removes a lot of code.

If we don't get a review from Patrick today, alternatively we could land this minimal patch.

Comment 5

[Patrick Brunschwig]

I'll review the patch this afternoon (ca. 17:30).

Comment 6

[Kai Engert [:KaiE:]]

Phabricator has a limitation, it allows neither Rob nor me to mark the patch as reviewed.

However, my initial patch was a one line obvious thing. And Rob did the real improvement patch.

r=kaie on Rob's improvement, and r=rjl (from Matrix) on my initial line to enable it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f0676c4790a1
Build/Include the OpenPGP code by default in comm-central. r=kaie,r=rjl

Comment 8

[Magnus Melin [:mkmelin]]

Yay!