Closed Bug 1628424 Opened 6 months ago Closed 5 months ago

Build/Include the OpenPGP code by default in comm-central

Categories

(MailNews Core :: Security: OpenPGP, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: KaiE, Assigned: KaiE)

References

(Depends on 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

The OpenPGP code should soon be ready for initial testing in nightly/daily Thunderbird builds. To enable it, we can flip the build pref.

See Also: → 1595325

This needs to land at the same time as bug 1625135, to ensure existing tests will continue to pass.

To actually being able to use the code, we need the RNP library and dependencies, as tracked in bug 1621785.
However, it's not a strict dependency at this time, because with the changes from bug 1625574, we should be able to fail gracefull, and non-OpenPGP code still runs.

Depends on: 1625135, 1621785
Assignee: nobody → kaie
Status: NEW → ASSIGNED
Depends on: 1630369
Depends on: 1630376
Depends on: 1631627

We need the patch "Remove old migration code and setup wizard" from bug 1631019 before enabling by default.
Without it, we get a test failure, with the symptom described in bug 1631019 comment 3.

Depends on: 1631019
Attached patch disable-wizard-hotfix.patch (obsolete) — Splinter Review

(In reply to Kai Engert (:KaiE:) from comment #3)

We need the patch "Remove old migration code and setup wizard" from bug 1631019 before enabling by default.
Without it, we get a test failure, with the symptom described in bug 1631019 comment 3.

That patch is a little bigger and removes a lot of code.

If we don't get a review from Patrick today, alternatively we could land this minimal patch.

I'll review the patch this afternoon (ca. 17:30).

Attachment #9142334 - Attachment is obsolete: true

Phabricator has a limitation, it allows neither Rob nor me to mark the patch as reviewed.

However, my initial patch was a one line obvious thing. And Rob did the real improvement patch.

r=kaie on Rob's improvement, and r=rjl (from Matrix) on my initial line to enable it.

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/f0676c4790a1
Build/Include the OpenPGP code by default in comm-central. r=kaie,r=rjl

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Yay!

Target Milestone: --- → Thunderbird 77.0
Depends on: 1632337
Depends on: 1632343
Regressions: 1632343
You need to log in before you can comment on or make changes to this bug.