1630511 - Replace MOZ_MUST_USE with [[nodiscard]] in netwerk

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Chris Peterson [:cpeterson]]

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1630511 - Replace MOZ_MUST_USE with [[nodiscard]] in netwerk. r=dragana

Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09cf4a063a09
Replace MOZ_MUST_USE with [[nodiscard]] in netwerk. r=necko-reviewers,dragana

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/09cf4a063a09