1630593 - Have gecko trees use their own idl parser copy to avoid mismatches

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

https://bugzilla.mozilla.org/show_bug.cgi?id=1621359 updated the IDL parser in m-c tip, which searchfox uses for IDL parsing on all trees (including esr68). However the new IDL parser fails on the esr68 version of some idl files:

Syntax error in IDL /mnt/index-scratch/mozilla-esr68/gecko-dev/widget/nsIDragSession.idl
Traceback (most recent call last):
  File "/home/ubuntu/mozsearch/scripts/idl-analyze.py", line 259, in <module>
    raise e
xpidl.IDLError: error: unrecognized input, /mnt/index-scratch/mozilla-esr68/gecko-dev/widget/nsIDragSession.idl line 14:13
native nsSize (nsSize);
             ^
Syntax error in IDL /mnt/index-scratch/mozilla-esr68/gecko-dev/xpcom/base/nsICycleCollectorListener.idl
Traceback (most recent call last):
  File "/home/ubuntu/mozsearch/scripts/idl-analyze.py", line 259, in <module>
    raise e
xpidl.IDLError: error: unrecognized input, /mnt/index-scratch/mozilla-esr68/gecko-dev/xpcom/base/nsICycleCollectorListener.idl line 13:38
[ptr] native nsCycleCollectorLoggerPtr (nsCycleCollectorLogger);
                                      ^

We should fix this by having searchfox use the in-tree IDL parser if there is one.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozsearch/mozsearch/pull/300

Comment 2

[Andrew McCreight [:mccr8]]

This fix is obviously a lot nicer, but for this particular case we could just uplift the trivial XPIDL fixup patch to esr68 ( https://hg.mozilla.org/mozilla-central/rev/fe6f888d24b8 ).

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Andrew McCreight [:mccr8] from comment #2)

This fix is obviously a lot nicer, but for this particular case we could just uplift the trivial XPIDL fixup patch to esr68 ( https://hg.mozilla.org/mozilla-central/rev/fe6f888d24b8 ).

Yeah we could, but that seemed like a bit of a workaround for stuff hard-coded in searchfox. The fix wasn't too hard to write. I've merged it now, and killed the running mozilla-releases indexer and started a new one.