1630668 - TypeError when running `./mach try syntax`

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[William Durand [:willdurand] [OOO until Aug. 25]]

Hi, I wanted to push to Try and I reused a command I used yesterday (or the day before yesterday) but I received an error:

$ ./mach try syntax --no-artifact -b do -p win32,linux64,macosx64 -u mochitests,test-verify,xpcshell -t none
Error running mach:

    ['try', 'syntax', '--no-artifact', '-b', 'do', '-p', 'win32,linux64,macosx64', '-u', 'mochitests,test-verify,xpcshell', '-t', 'none']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: add_remove_files() takes exactly 2 arguments (1 given)

  File "/Users/williamdurand/projects/mozilla/gecko/tools/tryselect/mach_commands.py", line 416, in try_syntax
    return self.run(**kwargs)
  File "/Users/williamdurand/projects/mozilla/gecko/tools/tryselect/mach_commands.py", line 177, in run
    return mod.run(**kwargs)
  File "/Users/williamdurand/projects/mozilla/gecko/tools/tryselect/selectors/syntax.py", line 613, in run
    return at.run(**kwargs)
  File "/Users/williamdurand/projects/mozilla/gecko/tools/tryselect/selectors/syntax.py", line 608, in run
    closed_tree=kwargs["closed_tree"])
  File "/Users/williamdurand/projects/mozilla/gecko/tools/tryselect/push.py", line 178, in push_to_try
    vcs.add_remove_files(*changed_files)

Do I have to update some dependencies manually or something? (sorry if that's a silly question).

Otherwise, this could maybe be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1630047.

Comment 1

[Ricky Stewart]

Yeah, that patch is messed up. The method signatures of add_remove_files and forget_add_remove_files differ in incompatible ways across the parent class and the subclasses. I can get a fix in in a moment.

Comment 2

[Ricky Stewart]

Attachment: Bug 1630668 - Fix incompatible type signatures in subclasses of Repository

Comment 3

[William Durand [:willdurand] [OOO until Aug. 25]]

:rstewart thanks! I confirm applying the attached patch fixes the problem for me.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b411dd8c786a
Fix incompatible type signatures in subclasses of Repository r=dmajor

Comment 9

[Cameron McCormack (:heycam)]

FWIW with this and the bug 1630047 patch applied, I get this message when I do a ./mach try:

Nothing specified, nothing added.
Maybe you wanted to say 'git add .'?

The try push itself works fine though.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b411dd8c786a