1630840 - Browser action properties aren't updated in the current tab

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Geoff Lankow (:darktrojan)]

Calling things like browser.browserAction.enable with the tab ID of the current tab does not update the browser action in the current tab until switching tabs. We have a test that should've caught this, but it switches tabs every time it checks properties, so it didn't.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1630840-browseraction-properties-1.diff

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9141146 [details] [diff] [review]
1630840-browseraction-properties-1.diff

Review of attachment 9141146 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/71abdc0e3d3f
Fix updating browserAction properties in the current tab. r=mkmelin DONTBUILD

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

Calling things like browser.browserAction.enable with the tab ID of the current tab does not update the browser action in the current tab until switching tabs. We have a test that should've caught this, but it switches tabs every time it checks properties, so it didn't.

So the test isn't (easily) fixed?

Comment 5

[Geoff Lankow (:darktrojan)]

It's fixed. I added a new piece which doesn't switch tabs.

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 76.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/7bfa35b519a6