1630906 - [wpt-sync] Sync PR 6351 - [css-flex] Changes to test suite after review of files

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 6351 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/6351
Details from upstream follow.

Greg Whitworth <[e-mail]> wrote:

[css-flex] Changes to test suite after review of files

In hopes to get flex to rec, we reviewed the files that had 5 or less links to url fragments in the TR flex spec. Here is a rundown of why the below changes were done:

• flex-align-item-center.html: Covered by flexbox_align-items-center.html
• flex-items-flexibility.html: This is covered by the flex-grow tests
• flexbox_margin-left-ex.html: Update link to a more accurate location
• negative-margins-001.html: Update this & ref to reflect reality of implementations.
• flexbox_generated.html:* Update spec link to flex-containers like other tests
• flexbox_margin-auto-overflow-2.html: It's testing the same thing as flexbox_margin-auto-overflow.html
• flexbox_margin-collapse.html: Covered by flex-margin-no-collapse.html
• visibility-collapse-*.html: Doesn't link to a reftest and is covered by flexbox_visibility*.

I attached the file that we did our review on for tracking these change - flex-test-rec.xlsx

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4c3848c1980e09755e97dd76dbb91d8e5b277c0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fb67cebf5d7
[wpt PR 6351] - [css-flex] Changes to test suite after review of files, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d9990f6ac46
[wpt PR 6351] - [css-flex] Changes to test suite after review of files, a=testonly

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6d9990f6ac46