1631011 - 2 addons using compose.onBeforeSend will not both work

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Dave Royal]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

If two addons use compose.onBeforeSend then the first one to respond with {"cancel":false} will send the email. The response from the second one appears to be ignored.

The test I did to demonstrate this is described here:
https://thunderbird.topicbox.com/groups/addons/T8a984c3fb306a535

Addons such as my Limit non-BCC recipients, which may require interaction, are likely not to work if another addon does something quick, such as add a recipient.

Comment 1

[Firefox Bug Husbandry Bot]

Resetting severity to default of --.

Comment 2

[Geoff Lankow (:darktrojan)]

Thanks for filing a bug I was already working on! Save me doing it :-)

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1631011-onbeforesend-sequential-1.diff

We have to fire each listener in sequence. I knew that but clearly I'd forgotten about it somewhere along the line.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9141926 [details] [diff] [review]
1631011-onbeforesend-sequential-1.diff

Review of attachment 9141926 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf38a1ba950e
Fire compose.onBeforeSend sequentially instead of all at once. r=mkmelin DONTBUILD

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9141926 [details] [diff] [review]
1631011-onbeforesend-sequential-1.diff

approved for beta

Comment 7

[Rob Lemley [:rjl]]

In order to get this patch to apply to comm-beta I also had to take Bug 1619057 as the changes overlap. Bug 1629023 might be needed as well.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 76.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/9c50eec1c6cd